Skip to content

Commit 67c7a3c

Browse files
committed
Add os compatibility to manifests
Microsoft version apis distinguish operating systems beyond window 8 if there isn't a manifest entry for os compatibility.
1 parent bae340a commit 67c7a3c

File tree

3 files changed

+41
-0
lines changed

3 files changed

+41
-0
lines changed

contrib/win32/openssh/ssh.vcxproj

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,9 @@
114114
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-Win32-Debug-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
115115
<AdditionalDependencies>bcrypt.lib;Userenv.lib;Ws2_32.lib;Secur32.lib;Shlwapi.lib;openbsd_compat.lib;libssh.lib;win32compat.lib;libeay32.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
116116
</Link>
117+
<Manifest>
118+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
119+
</Manifest>
117120
</ItemDefinitionGroup>
118121
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
119122
<ClCompile>
@@ -133,6 +136,9 @@
133136
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-x64-Debug-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
134137
<AdditionalDependencies>bcrypt.lib;Userenv.lib;Ws2_32.lib;Secur32.lib;Shlwapi.lib;openbsd_compat.lib;libssh.lib;win32compat.lib;libeay32.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
135138
</Link>
139+
<Manifest>
140+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
141+
</Manifest>
136142
</ItemDefinitionGroup>
137143
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
138144
<ClCompile>
@@ -154,6 +160,9 @@
154160
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-Win32-Release-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
155161
<AdditionalDependencies>bcrypt.lib;Userenv.lib;Ws2_32.lib;Secur32.lib;Shlwapi.lib;openbsd_compat.lib;libssh.lib;win32compat.lib;libeay32.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
156162
</Link>
163+
<Manifest>
164+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
165+
</Manifest>
157166
</ItemDefinitionGroup>
158167
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
159168
<ClCompile>
@@ -176,6 +185,9 @@
176185
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-x64-Release-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
177186
<AdditionalDependencies>bcrypt.lib;Userenv.lib;Ws2_32.lib;Secur32.lib;Shlwapi.lib;openbsd_compat.lib;libssh.lib;win32compat.lib;libeay32.lib;kernel32.lib;user32.lib;gdi32.lib;winspool.lib;comdlg32.lib;advapi32.lib;shell32.lib;ole32.lib;oleaut32.lib;uuid.lib;odbc32.lib;odbccp32.lib;%(AdditionalDependencies)</AdditionalDependencies>
178187
</Link>
188+
<Manifest>
189+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
190+
</Manifest>
179191
</ItemDefinitionGroup>
180192
<ItemGroup>
181193
<ClInclude Include="$(OpenSSH-Src-Path)acss.h" />

contrib/win32/openssh/sshd.vcxproj

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,9 @@
110110
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-Win32-Debug-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
111111
<ForceFileOutput>MultiplyDefinedSymbolOnly</ForceFileOutput>
112112
</Link>
113+
<Manifest>
114+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
115+
</Manifest>
113116
</ItemDefinitionGroup>
114117
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">
115118
<ClCompile>
@@ -130,6 +133,9 @@
130133
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-x64-Debug-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
131134
<ForceFileOutput>MultiplyDefinedSymbolOnly</ForceFileOutput>
132135
</Link>
136+
<Manifest>
137+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
138+
</Manifest>
133139
</ItemDefinitionGroup>
134140
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|Win32'">
135141
<ClCompile>
@@ -153,6 +159,9 @@
153159
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-Win32-Release-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
154160
<ForceFileOutput>MultiplyDefinedSymbolOnly</ForceFileOutput>
155161
</Link>
162+
<Manifest>
163+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
164+
</Manifest>
156165
</ItemDefinitionGroup>
157166
<ItemDefinitionGroup Condition="'$(Configuration)|$(Platform)'=='Release|x64'">
158167
<ClCompile>
@@ -177,6 +186,9 @@
177186
<AdditionalLibraryDirectories>$(OpenSSH-Lib-Path)$(Platform)\$(Configuration);$(OpenSSL-x64-Release-Path)lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
178187
<ForceFileOutput>MultiplyDefinedSymbolOnly</ForceFileOutput>
179188
</Link>
189+
<Manifest>
190+
<AdditionalManifestFiles>targetos.manifest</AdditionalManifestFiles>
191+
</Manifest>
180192
</ItemDefinitionGroup>
181193
<ItemGroup>
182194
<ClCompile Include="$(OpenSSH-Src-Path)audit-bsm.c" />
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
2+
<assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">
3+
<compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
4+
<application>
5+
<!-- Windows 10 -->
6+
<supportedOS Id="{8e0f7a12-bfb3-4fe8-b9a5-48fd50a15a9a}"/>
7+
* <!-- Windows 8.1 -->
8+
* <supportedOS Id="{1f676c76-80e1-4239-95bb-83d0f6d0da78}"/>
9+
<!-- Windows Vista -->
10+
<supportedOS Id="{e2011457-1546-43c5-a5fe-008deee3d3f0}"/>
11+
<!-- Windows 7 -->
12+
<supportedOS Id="{35138b9a-5d96-4fbd-8e2d-a2440225f93a}"/>
13+
<!-- Windows 8 -->
14+
<supportedOS Id="{4a2f28e3-53b9-4441-ba9c-d69d4a4a6e38}"/>
15+
</application>
16+
</compatibility>
17+
</assembly>

0 commit comments

Comments
 (0)