There shouldn't be any "*" when entering a password or passphrase

quamrulmina · quamrulmina · commit 89452c8a2f5a · 2015-10-20T19:23:18.000-05:00
There shouldn't be any "*" when entering a password or passphrase for better security. Linux/Unix openssh works the same way - without any "*". Great suggestion by Mark Hahnel in comments of Issue #5
diff --git a/readpass.c b/readpass.c
@@ -362,7 +362,7 @@ read_passphrase(const char *prompt, int flags)
 		}
 		else {
 
-			_putch( (int) '*' ); // show a star in place of what is typed
+			//_putch( (int) '*' ); // show a star in place of what is typed
 			len++; // keep reading in the loop
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -362,7 +362,7 @@ read_passphrase(const char *prompt, int flags)`
`362`	`362`	`}`
`363`	`363`	`else {`
`364`	`364`
`365`		`- _putch( (int) '*' ); // show a star in place of what is typed`
	`365`	`+ //_putch( (int) '*' ); // show a star in place of what is typed`
`366`	`366`	`len++; // keep reading in the loop`
`367`	`367`	`}`
`368`	`368`	`}`