Merge remote-tracking branch 'upstream/main'

Author: jcmnn

.cargo/config.toml

@@ -57,7 +57,6 @@ rustflags = [
     "-Wclippy::map_err_ignore",
     "-Wclippy::map_flatten",
     "-Wclippy::map_unwrap_or",
-    "-Wclippy::match_on_vec_items",
     "-Wclippy::match_same_arms",
     "-Wclippy::match_wild_err_arm",
     "-Wclippy::match_wildcard_for_single_variants",

.github/workflows/ci.yaml

@@ -175,8 +175,16 @@ jobs:
   test_success:
     runs-on: ubuntu-24.04
     needs: [test, compiletest, difftest, android]
+    # Hack for buggy GitHub Actions behavior with skipped checks: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
+    if: ${{ always() }}
     steps:
-    - run: echo "All test jobs passed"
+      # Another hack is to actually check the status of the dependencies or else it'll fall through
+      - run: |
+          echo "Checking statuses..."
+          [[ "${{ needs.test.result }}" == "success" ]] || exit 1
+          [[ "${{ needs.compiletest.result }}" == "success" ]] || exit 1
+          [[ "${{ needs.difftest.result }}" == "success" ]] || exit 1
+          [[ "${{ needs.android.result }}" == "success" ]] || exit 1
 
   lint:
     name: Lint