Skip to content

Commit 4c43bf2

Browse files
Fix-Peer Review Buttons not get disabled after voting an Image for deletion (commons-app#5519)
* Fix-Peer Review Buttons not get disabled after voting an Image for deletion * Fix
1 parent 4264164 commit 4c43bf2

File tree

3 files changed

+25
-0
lines changed

3 files changed

+25
-0
lines changed

app/src/main/java/fr/free/nrw/commons/delete/DeleteHelper.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,8 @@ public void askReasonAndExecute(Media media,
205205
});
206206

207207
alert.setPositiveButton(context.getString(R.string.ok), (dialogInterface, i) -> {
208+
reviewCallback.disableButtons();
209+
208210

209211
String reason = getLocalizedResources(context, Locale.ENGLISH).getString(R.string.delete_helper_ask_alert_set_positive_button_reason) + " ";
210212

@@ -229,6 +231,7 @@ public void askReasonAndExecute(Media media,
229231
} else {
230232
reviewCallback.onFailure();
231233
}
234+
reviewCallback.enableButtons();
232235
});
233236

234237
});

app/src/main/java/fr/free/nrw/commons/review/ReviewController.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -191,5 +191,9 @@ public interface ReviewCallback {
191191
void onSuccess();
192192

193193
void onFailure();
194+
195+
void disableButtons();
196+
197+
void enableButtons();
194198
}
195199
}

app/src/main/java/fr/free/nrw/commons/review/ReviewImageFragment.java

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,24 @@ public void onSuccess() {
181181
public void onFailure() {
182182
//do nothing
183183
}
184+
185+
/**
186+
* This function is called when an image is being loaded
187+
* to disable the review buttons
188+
*/
189+
@Override
190+
public void disableButtons() {
191+
ReviewImageFragment.this.disableButtons();
192+
}
193+
194+
/**
195+
* This function is called when an image has
196+
* been loaded to enable the review buttons.
197+
*/
198+
@Override
199+
public void enableButtons() {
200+
ReviewImageFragment.this.enableButtons();
201+
}
184202
};
185203
}
186204

0 commit comments

Comments
 (0)