Enhancement - Nearby banner shows Item without image (commons-app#5468)

* Enhancement Nearby banner shows Item without image

* spacing

* Enhancement Nearby banner shows Item without image

* spacing

* Fix Crash

* Reverted "Fix Crash"

This reverts commit a41c936.

* Fixed

* Fix null ___location

* Fix Conflict

* Show Only Items that exists

---------

Co-authored-by: shashankkumar <[email protected]>
Co-authored-by: Nicolas Raoul <[email protected]>

Author: 3 people

app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java

@@ -538,11 +538,23 @@ private void updateClosestNearbyCardViewInfo() {
 
     private void updateNearbyNotification(@Nullable NearbyController.NearbyPlacesInfo nearbyPlacesInfo) {
         if (nearbyPlacesInfo != null && nearbyPlacesInfo.placeList != null && nearbyPlacesInfo.placeList.size() > 0) {
-            Place closestNearbyPlace = nearbyPlacesInfo.placeList.get(0);
-            String distance = formatDistanceBetween(curLatLng, closestNearbyPlace.___location);
-            closestNearbyPlace.setDistance(distance);
-            direction = (float) computeBearing(curLatLng, closestNearbyPlace.___location);
-            nearbyNotificationCardView.updateContent(closestNearbyPlace);
+            Place closestNearbyPlace = null;
+            // Find the first nearby place that has no image and exists
+            for (Place place : nearbyPlacesInfo.placeList) {
+                if (place.pic.equals("") && place.exists) {
+                    closestNearbyPlace = place;
+                    break;
+                }
+            }
+
+            if(closestNearbyPlace == null) {
+                nearbyNotificationCardView.setVisibility(View.GONE);
+            }else{
+                String distance = formatDistanceBetween(curLatLng, closestNearbyPlace.___location);
+                closestNearbyPlace.setDistance(distance);
+                direction = (float) computeBearing(curLatLng, closestNearbyPlace.___location);
+                nearbyNotificationCardView.updateContent(closestNearbyPlace);
+            }
         } else {
             // Means that no close nearby place is found
             nearbyNotificationCardView.setVisibility(View.GONE);