Skip to content

Commit a7c99be

Browse files
authored
Remove the animations from the command palette too (microsoft#17335)
Exactly the same as microsoft#17247, but also just applied to the command palette. It's so much better guys.
1 parent 0bd0eea commit a7c99be

File tree

3 files changed

+21
-19
lines changed

3 files changed

+21
-19
lines changed

src/cascadia/TerminalApp/App.xaml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,25 @@
146146
</Setter>
147147
</Style>
148148

149+
<!--
150+
Remove all item animations from the suggestions UI and command
151+
palette. They're entirely too slow to let that UI be usable.
152+
-->
153+
<Style x:Key="NoAnimationsPlease"
154+
TargetType="ListView">
155+
<Setter Property="ItemContainerTransitions">
156+
<Setter.Value>
157+
<TransitionCollection>
158+
<!-- (deleted transitions are left for reference for what we removed) -->
159+
<ContentThemeTransition />
160+
<!--<AddDeleteThemeTransition/>-->
161+
<!--<ReorderThemeTransition/>-->
162+
<!--<EntranceThemeTransition IsStaggeringEnabled="False"/>-->
163+
</TransitionCollection>
164+
</Setter.Value>
165+
</Setter>
166+
</Style>
167+
149168
<ResourceDictionary.ThemeDictionaries>
150169
<ResourceDictionary x:Key="Dark">
151170
<!-- Define resources for Dark mode here -->

src/cascadia/TerminalApp/CommandPalette.xaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,8 @@
403403
ItemClick="_listItemClicked"
404404
ItemsSource="{x:Bind FilteredActions}"
405405
SelectionChanged="_listItemSelectionChanged"
406-
SelectionMode="Single" />
406+
SelectionMode="Single"
407+
Style="{StaticResource NoAnimationsPlease}" />
407408

408409
</Grid>
409410

src/cascadia/TerminalApp/SuggestionsControl.xaml

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -100,24 +100,6 @@
100100
GeneralItemTemplate="{StaticResource GeneralItemTemplate}"
101101
NestedItemTemplate="{StaticResource NestedItemTemplate}" />
102102

103-
<!--
104-
Remove all item animations from the suggestions UI. They're
105-
entirely too slow to let that UI be usable.
106-
-->
107-
<Style x:Key="NoAnimationsPlease"
108-
TargetType="ListView">
109-
<Setter Property="ItemContainerTransitions">
110-
<Setter.Value>
111-
<TransitionCollection>
112-
<!-- (deleted transitions are left for reference for what we removed) -->
113-
<ContentThemeTransition />
114-
<!--<AddDeleteThemeTransition/>-->
115-
<!--<ReorderThemeTransition/>-->
116-
<!--<EntranceThemeTransition IsStaggeringEnabled="False"/>-->
117-
</TransitionCollection>
118-
</Setter.Value>
119-
</Setter>
120-
</Style>
121103
</ResourceDictionary>
122104
</UserControl.Resources>
123105

0 commit comments

Comments
 (0)