Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NginxProxyManager/nginx-proxy-manager
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: Whatchawnt/nginx-proxy-manager
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
  • 3 commits
  • 1 file changed
  • 1 contributor

Commits on Jul 14, 2025

  1. Create generate-p12.sh Script 

    1. Added ability to generate .p12 file (fullPKCS12.p12) from the certificates, private keys, and certificate chain. The script downloads the root certificate from the copy of the intermediate certificate.
2. Added simlink for /etc/letsencrypt/live/npm-10/fullpkcs12.sh to  /etc/letsencrypt/live/npm-10/fullpkcs12-#.sh (Where -# is the number appended based on the number that comes after the private key in the same directory, so if privkey1.pem is in the folder then the script will generate fullpkcs12-1.sh)

Still Yet To do:
1. Add ability for changing "npm-10" by taking in an argument by the script.
    @Whatchawnt
    Whatchawnt authored Jul 14, 2025
    Configuration menu
    Copy the full SHA
    ee2072b View commit details
    Browse the repository at this point in the history

  2. Update generate-p12.sh 

    1. Added Option to parse in the npm value (I.E. npm-10)  as a required variable which is the npm value that the certificate files are stored in (I.E. '/etc/letsencrypt/live/npm-10/'   and   '/etc/letsencrypt/archive/npm-10/' )
2. Added the option to parse a password into the script to be used as the p12 password for securing the private key within the generated PKCS12 file.
3. Added Variable in script to allow the user to keep the root certificate that the script generates ($KEEP_ROOT_CERTIFICATE which it is set to true by default).
4. Added Simlinks for the .p12 file (follows the current convention)
5. Added Simlink for the root certificate, if the user chooses to keep the root certificate by setting the variable $KEEP_ROOT_CERTIFICATE to true (follows the current convention)
4. Added automatic cleanup for temporary files as well as the root file when the variable $KEEP_ROOT_CERTIFICATE is set to false.
    @Whatchawnt
    Whatchawnt authored Jul 14, 2025
    Configuration menu
    Copy the full SHA
    00a5008 View commit details
    Browse the repository at this point in the history

  3. Update generate-p12.sh 

    1. Added Option to parse in the npm value (I.E. npm-10)  as a required variable which is the npm value that the certificate files are stored in (I.E. '/etc/letsencrypt/live/npm-10/'   and   '/etc/letsencrypt/archive/npm-10/' )
2. Added the option to parse a password into the script to be used as the p12 password for securing the private key within the generated PKCS12 file.
3. Added Variable in script to allow the user to keep the root certificate that the script generates ($KEEP_ROOT_CERTIFICATE which it is set to true by default).
4. Added Simlinks for the .p12 file (follows the current convention)
5. Added Simlink for the root certificate, if the user chooses to keep the root certificate by setting the variable $KEEP_ROOT_CERTIFICATE to true (follows the current convention)
6. Added automatic cleanup for temporary files as well as the root file when the variable $KEEP_ROOT_CERTIFICATE is set to false.
7. Changed Print Help Text to use echo command.
    @Whatchawnt
    Whatchawnt authored Jul 14, 2025
    Configuration menu
    Copy the full SHA
    da7c0d5 View commit details
    Browse the repository at this point in the history
Loading