Skip to content
This repository was archived by the owner on May 26, 2023. It is now read-only.

Commit 0718344

Browse files
fix(typescript): Update to typescript 2.4 and @uirouter/core 5.0.5
1 parent 5131e6c commit 0718344

File tree

4 files changed

+415
-257
lines changed

4 files changed

+415
-257
lines changed

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@
6969
"jsnext:main": "lib-esm/index.js",
7070
"typings": "lib/index.d.ts",
7171
"dependencies": {
72-
"@uirouter/core": "5.0.3"
72+
"@uirouter/core": "5.0.5"
7373
},
7474
"peerDependencies": {
7575
"angular": ">=1.2.0"
@@ -115,7 +115,7 @@
115115
"typedoc-plugin-external-module-name": "^1.0.2",
116116
"typedoc-plugin-internal-external": "^1.0.0",
117117
"typedoc-plugin-ui-router": "^1.0.0",
118-
"typescript": "^2.1.4",
118+
"typescript": "~2.4.0",
119119
"ui-router-typedoc-themes": "^1.0.1",
120120
"watch": "^0.18.0",
121121
"webpack": "1.x",

src/stateFilters.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import { Obj, StateService, StateOrName } from "@uirouter/core";
1515
*/
1616
$IsStateFilter.$inject = ['$state'];
1717
export function $IsStateFilter($state: StateService) {
18-
var isFilter: any = function(state: StateOrName, params: Obj, options?: { relative?: boolean }) {
18+
var isFilter: any = function(state: StateOrName, params: Obj, options?: { relative?: StateOrName }) {
1919
return $state.is(state, params, options);
2020
};
2121
isFilter.$stateful = true;
@@ -34,7 +34,7 @@ export function $IsStateFilter($state: StateService) {
3434
*/
3535
$IncludedByStateFilter.$inject = ['$state'];
3636
export function $IncludedByStateFilter($state: StateService) {
37-
var includesFilter: any = function(state: StateOrName, params: Obj, options: Obj) {
37+
var includesFilter: any = function(state: StateOrName, params: Obj, options: { relative?: StateOrName }) {
3838
return $state.includes(state, params, options);
3939
};
4040
includesFilter.$stateful = true;

src/templateFactory.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,19 @@ export class TemplateFactory implements TemplateFactoryProvider {
4242
* @return {string|object} The template html as a string, or a promise for
4343
* that string,or `null` if no template is configured.
4444
*/
45-
fromConfig(config: Ng1ViewDeclaration, params: any, context: ResolveContext) {
45+
fromConfig(config: Ng1ViewDeclaration, params: any, context: ResolveContext): Promise<{ template?: string, component?: string }> {
4646
const defaultTemplate = "<ui-view></ui-view>";
4747

48-
const asTemplate = (result) => services.$q.when(result).then(str => ({ template: str }));
48+
const asTemplate = (result) => services.$q.when(result).then(str => ({ template: str }));
4949
const asComponent = (result) => services.$q.when(result).then(str => ({ component: str }));
5050

5151
return (
52-
isDefined(config.template) ? asTemplate(this.fromString(config.template, params)) :
53-
isDefined(config.templateUrl) ? asTemplate(this.fromUrl(config.templateUrl, params)) :
54-
isDefined(config.templateProvider) ? asTemplate(this.fromProvider(config.templateProvider, params, context)) :
55-
isDefined(config.component) ? asComponent(config.component) :
56-
isDefined(config.componentProvider) ? asComponent(this.fromComponentProvider(config.componentProvider, params, context)) :
57-
asTemplate(defaultTemplate)
52+
isDefined(config.template) ? asTemplate(this.fromString(config.template, params)) :
53+
isDefined(config.templateUrl) ? asTemplate(this.fromUrl(config.templateUrl, params)) :
54+
isDefined(config.templateProvider) ? asTemplate(this.fromProvider(config.templateProvider, params, context)) :
55+
isDefined(config.component) ? asComponent(config.component) :
56+
isDefined(config.componentProvider) ? asComponent(this.fromComponentProvider(config.componentProvider, params, context)) :
57+
asTemplate(defaultTemplate)
5858
);
5959
};
6060

0 commit comments

Comments
 (0)