Merge pull request #103 from GFWagnitz/GFWagnitz-patch-1

bufferoverflow · web-flow · commit e6787ffd354e · 2019-12-10T06:19:14.000+01:00
fix(auth): allows matching of mixed-case usernames
diff --git a/src/gitlab.ts b/src/gitlab.ts
@@ -97,7 +97,7 @@ export default class VerdaccioGitLab implements VerdaccioGitLabPlugin {
 
     GitlabAPI.Users.current()
       .then(response => {
-        if (user !== response.username) {
+        if (user.toLowerCase() !== response.username.toLowerCase()) {
           return cb(getUnauthorized('wrong gitlab username'));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ export default class VerdaccioGitLab implements VerdaccioGitLabPlugin {`
`97`	`97`
`98`	`98`	`GitlabAPI.Users.current()`
`99`	`99`	`.then(response => {`
`100`		`- if (user !== response.username) {`
	`100`	`+ if (user.toLowerCase() !== response.username.toLowerCase()) {`
`101`	`101`	`return cb(getUnauthorized('wrong gitlab username'));`
`102`	`102`	`}`
`103`	`103`