Skip to content

Commit 699cc10

Browse files
jzheauxjzheaux
authored
Merge pull request eugenp#8081 from amit2103/BAEL-18428
[BAEL-18428] - Check modules that don't use our standard parents
2 parents e361c9a + d6b68de commit 699cc10

File tree

5 files changed

+243
-224
lines changed

5 files changed

+243
-224
lines changed

‎micronaut/pom.xml

Lines changed: 122 additions & 116 deletions
Original file line numberDiff line numberDiff line change
@@ -1,136 +1,142 @@
11
<?xml version="1.0" encoding="UTF-8"?><project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
2-
<modelVersion>4.0.0</modelVersion>
3-
<groupId>com.baeldung.micronaut</groupId>
4-
<artifactId>micronaut</artifactId>
5-
<version>0.1</version>
6-
<name>micronaut</name>
2+
<modelVersion>4.0.0</modelVersion>
3+
<groupId>com.baeldung.micronaut</groupId>
4+
<artifactId>micronaut</artifactId>
5+
<version>0.1</version>
6+
<name>micronaut</name>
77

8-
<dependencyManagement>
8+
<parent>
9+
<groupId>com.baeldung</groupId>
10+
<artifactId>parent-modules</artifactId>
11+
<version>1.0.0-SNAPSHOT</version>
12+
</parent>
13+
14+
<dependencyManagement>
15+
<dependencies>
16+
<dependency>
17+
<groupId>io.micronaut</groupId>
18+
<artifactId>bom</artifactId>
19+
<version>${micronaut.version}</version>
20+
<type>pom</type>
21+
<scope>import</scope>
22+
</dependency>
23+
</dependencies>
24+
</dependencyManagement>
925
<dependencies>
10-
<dependency>
11-
<groupId>io.micronaut</groupId>
12-
<artifactId>bom</artifactId>
13-
<version>${micronaut.version}</version>
14-
<type>pom</type>
15-
<scope>import</scope>
16-
</dependency>
17-
</dependencies>
18-
</dependencyManagement>
19-
<dependencies>
2026
<dependency>
21-
<groupId>io.micronaut</groupId>
22-
<artifactId>http-client</artifactId>
23-
<scope>compile</scope>
27+
<groupId>io.micronaut</groupId>
28+
<artifactId>http-client</artifactId>
29+
<scope>compile</scope>
2430
</dependency>
2531
<dependency>
26-
<groupId>io.micronaut</groupId>
27-
<artifactId>http-server-netty</artifactId>
28-
<scope>compile</scope>
32+
<groupId>io.micronaut</groupId>
33+
<artifactId>http-server-netty</artifactId>
34+
<scope>compile</scope>
2935
</dependency>
3036
<dependency>
31-
<groupId>io.micronaut</groupId>
32-
<artifactId>inject</artifactId>
33-
<scope>compile</scope>
37+
<groupId>io.micronaut</groupId>
38+
<artifactId>inject</artifactId>
39+
<scope>compile</scope>
3440
</dependency>
3541
<dependency>
36-
<groupId>io.micronaut</groupId>
37-
<artifactId>runtime</artifactId>
38-
<scope>compile</scope>
42+
<groupId>io.micronaut</groupId>
43+
<artifactId>runtime</artifactId>
44+
<scope>compile</scope>
3945
</dependency>
4046
<dependency>
41-
<groupId>javax.annotation</groupId>
42-
<artifactId>javax.annotation-api</artifactId>
43-
<version>1.3.2</version>
44-
<scope>compile</scope>
47+
<groupId>javax.annotation</groupId>
48+
<artifactId>javax.annotation-api</artifactId>
49+
<version>1.3.2</version>
50+
<scope>compile</scope>
4551
</dependency>
4652
<dependency>
47-
<groupId>io.micronaut</groupId>
48-
<artifactId>inject-java</artifactId>
49-
<scope>provided</scope>
53+
<groupId>io.micronaut</groupId>
54+
<artifactId>inject-java</artifactId>
55+
<scope>provided</scope>
5056
</dependency>
5157
<dependency>
52-
<groupId>ch.qos.logback</groupId>
53-
<artifactId>logback-classic</artifactId>
54-
<version>1.2.3</version>
55-
<scope>runtime</scope>
58+
<groupId>ch.qos.logback</groupId>
59+
<artifactId>logback-classic</artifactId>
60+
<version>1.2.3</version>
61+
<scope>runtime</scope>
5662
</dependency>
5763
<dependency>
58-
<groupId>junit</groupId>
59-
<artifactId>junit</artifactId>
60-
<version>4.12</version>
61-
<scope>test</scope>
64+
<groupId>junit</groupId>
65+
<artifactId>junit</artifactId>
66+
<version>4.12</version>
67+
<scope>test</scope>
6268
</dependency>
63-
<dependency>
64-
<groupId>io.projectreactor</groupId>
65-
<artifactId>reactor-core</artifactId>
66-
<version>3.1.6.RELEASE</version>
67-
</dependency>
68-
</dependencies>
69-
<build>
70-
<plugins>
71-
<plugin>
72-
<groupId>org.apache.maven.plugins</groupId>
73-
<artifactId>maven-shade-plugin</artifactId>
74-
<version>3.1.0</version>
75-
<executions>
76-
<execution>
77-
<phase>package</phase>
78-
<goals>
79-
<goal>shade</goal>
80-
</goals>
81-
<configuration>
82-
<transformers>
83-
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
84-
<mainClass>${exec.mainClass}</mainClass>
85-
</transformer>
86-
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
87-
</transformers>
88-
</configuration>
89-
</execution>
90-
</executions>
91-
</plugin>
92-
<plugin>
93-
<groupId>org.codehaus.mojo</groupId>
94-
<artifactId>exec-maven-plugin</artifactId>
95-
<version>1.6.0</version>
96-
<configuration>
97-
<executable>java</executable>
98-
<arguments>
99-
<argument>-classpath</argument>
100-
<classpath/>
101-
<argument>${exec.mainClass}</argument>
102-
</arguments>
103-
</configuration>
104-
</plugin>
105-
</plugins>
106-
<pluginManagement>
107-
<plugins>
108-
<plugin>
109-
<groupId>org.apache.maven.plugins</groupId>
110-
<artifactId>maven-compiler-plugin</artifactId>
111-
<version>3.7.0</version>
112-
<configuration>
113-
<source>${jdk.version}</source>
114-
<target>${jdk.version}</target>
115-
<compilerArgs>
116-
<arg>-parameters</arg>
117-
</compilerArgs>
118-
<annotationProcessorPaths>
119-
<path>
120-
<groupId>io.micronaut</groupId>
121-
<artifactId>inject-java</artifactId>
122-
<version>${micronaut.version}</version>
123-
</path>
124-
</annotationProcessorPaths>
125-
</configuration>
126-
</plugin>
127-
</plugins>
128-
</pluginManagement>
129-
</build>
130-
131-
<properties>
132-
<exec.mainClass>com.baeldung.micronaut.helloworld.server.ServerApplication</exec.mainClass>
133-
<micronaut.version>1.0.0.RC2</micronaut.version>
134-
<jdk.version>1.8</jdk.version>
135-
</properties>
69+
<dependency>
70+
<groupId>io.projectreactor</groupId>
71+
<artifactId>reactor-core</artifactId>
72+
<version>3.1.6.RELEASE</version>
73+
</dependency>
74+
</dependencies>
75+
<build>
76+
<plugins>
77+
<plugin>
78+
<groupId>org.apache.maven.plugins</groupId>
79+
<artifactId>maven-shade-plugin</artifactId>
80+
<version>3.1.0</version>
81+
<executions>
82+
<execution>
83+
<phase>package</phase>
84+
<goals>
85+
<goal>shade</goal>
86+
</goals>
87+
<configuration>
88+
<transformers>
89+
<transformer implementation="org.apache.maven.plugins.shade.resource.ManifestResourceTransformer">
90+
<mainClass>${exec.mainClass}</mainClass>
91+
</transformer>
92+
<transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer"/>
93+
</transformers>
94+
</configuration>
95+
</execution>
96+
</executions>
97+
</plugin>
98+
<plugin>
99+
<groupId>org.codehaus.mojo</groupId>
100+
<artifactId>exec-maven-plugin</artifactId>
101+
<version>1.6.0</version>
102+
<configuration>
103+
<executable>java</executable>
104+
<arguments>
105+
<argument>-classpath</argument>
106+
<classpath/>
107+
<argument>${exec.mainClass}</argument>
108+
</arguments>
109+
</configuration>
110+
</plugin>
111+
</plugins>
112+
<pluginManagement>
113+
<plugins>
114+
<plugin>
115+
<groupId>org.apache.maven.plugins</groupId>
116+
<artifactId>maven-compiler-plugin</artifactId>
117+
<version>3.7.0</version>
118+
<configuration>
119+
<source>${jdk.version}</source>
120+
<target>${jdk.version}</target>
121+
<compilerArgs>
122+
<arg>-parameters</arg>
123+
</compilerArgs>
124+
<annotationProcessorPaths>
125+
<path>
126+
<groupId>io.micronaut</groupId>
127+
<artifactId>inject-java</artifactId>
128+
<version>${micronaut.version}</version>
129+
</path>
130+
</annotationProcessorPaths>
131+
</configuration>
132+
</plugin>
133+
</plugins>
134+
</pluginManagement>
135+
</build>
136+
137+
<properties>
138+
<exec.mainClass>com.baeldung.micronaut.helloworld.server.ServerApplication</exec.mainClass>
139+
<micronaut.version>1.0.0.RC2</micronaut.version>
140+
<jdk.version>1.8</jdk.version>
141+
</properties>
136142
</project>

‎micronaut/src/test/java/com/baeldung/micronaut/helloworld/client/ConcreteGreetingClientTest.java renamed to ‎micronaut/src/test/java/com/baeldung/micronaut/helloworld/client/ConcreteGreetingClientUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import static junit.framework.TestCase.assertEquals;
1010

11-
public class ConcreteGreetingClientTest
11+
public class ConcreteGreetingClientUnitTest
1212
{
1313
private EmbeddedServer server;
1414
private ConcreteGreetingClient client;

‎micronaut/src/test/java/com/baeldung/micronaut/helloworld/client/GreetingClientTest.java renamed to ‎micronaut/src/test/java/com/baeldung/micronaut/helloworld/client/GreetingClientUnitTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
import static junit.framework.TestCase.assertEquals;
1010

11-
public class GreetingClientTest {
11+
public class GreetingClientUnitTest {
1212
private EmbeddedServer server;
1313
private GreetingClient client;
1414

‎persistence-modules/jnosql/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,13 @@
99
<name>jnosql</name>
1010
<packaging>pom</packaging>
1111

12+
<parent>
13+
<groupId>com.baeldung</groupId>
14+
<artifactId>parent-modules</artifactId>
15+
<version>1.0.0-SNAPSHOT</version>
16+
<relativePath>../../</relativePath>
17+
</parent>
18+
1219
<modules>
1320
<module>jnosql-diana</module>
1421
<module>jnosql-artemis</module>

0 commit comments

Comments
 (0)