Turbopack: name the module factory function (vercel#73553)

### What?

In development give the module factory a useful name, so it's clear in stack traces that this is the module evaluation part of the execution.

This also fixes some bugs with the stack trace parser, which seems to struggle if function names contain brackets. The automatically inferred function name would be the module id, which contains brackets.

Author: sokra

packages/next/src/next-devtools/dev-overlay/components/code-frame/code-frame.tsx

@@ -139,7 +139,6 @@ export const CODE_FRAME_STYLES = `
   }
 
   .code-frame-link [data-text] {
-    display: inline-flex;
     text-align: left;
     margin: auto 6px;
   }

test/development/acceptance-app/ReactRefreshLogBox.test.ts

@@ -93,12 +93,12 @@ describe('ReactRefreshLogBox app', () => {
          "description": "no",
          "environmentLabel": null,
          "label": "Runtime Error",
-         "source": "index.js (3:7) @ [project]/index.js [app-client] (ecmascript)
+         "source": "index.js (3:7) @ {module evaluation}
        > 3 | throw new Error('no')
            |       ^",
          "stack": [
-           "[project]/index.js [app-client] (ecmascript) index.js (3:7)",
-           "[project]/app/page.js [app-client] (ecmascript) app/page.js (2:1)",
+           "{module evaluation} index.js (3:7)",
+           "{module evaluation} app/page.js (2:1)",
          ],
        }
       `)
@@ -938,8 +938,7 @@ describe('ReactRefreshLogBox app', () => {
          "description": "test",
          "environmentLabel": null,
          "label": "Runtime Error",
-         "source": "index.js (3:11) @
-       {default export}
+         "source": "index.js (3:11) @ {default export}
        > 3 |     throw new Error('test')
            |           ^",
          "stack": [
@@ -1570,12 +1569,12 @@ export default function Home() {
          "description": "utils error",
          "environmentLabel": null,
          "label": "Runtime Error",
-         "source": "app/utils.ts (1:7) @ [project]/app/utils.ts [app-client] (ecmascript)
+         "source": "app/utils.ts (1:7) @ {module evaluation}
        > 1 | throw new Error('utils error')
            |       ^",
          "stack": [
-           "[project]/app/utils.ts [app-client] (ecmascript) app/utils.ts (1:7)",
-           "[project]/app/page.js [app-client] (ecmascript) app/page.js (2:1)",
+           "{module evaluation} app/utils.ts (1:7)",
+           "{module evaluation} app/page.js (2:1)",
          ],
        }
       `)

test/development/acceptance/ReactRefreshLogBox.test.ts

@@ -121,13 +121,13 @@ describe('ReactRefreshLogBox', () => {
            "description": "no",
            "environmentLabel": null,
            "label": "Runtime Error",
-           "source": "index.js (3:7) @ [project]/index.js [ssr] (ecmascript)
+           "source": "index.js (3:7) @ {module evaluation}
          > 3 | throw new Error('no')
              |       ^",
            "stack": [
-             "[project]/index.js [ssr] (ecmascript) index.js (3:7)",
-             "[project]/pages/index.js [ssr] (ecmascript) <module evaluation> pages/index.js (1:1)",
-             "[project]/pages/index.js [ssr] (ecmascript) pages/index.js (1:1)",
+             "{module evaluation} index.js (3:7)",
+             "{module evaluation} pages/index.js (1:1)",
+             "{module evaluation} pages/index.js (1:1)",
              "<FIXME-next-dist-dir>",
            ],
          }
@@ -162,13 +162,13 @@ describe('ReactRefreshLogBox', () => {
            "description": "no",
            "environmentLabel": null,
            "label": "Runtime Error",
-           "source": "index.js (3:7) @ [project]/index.js [ssr] (ecmascript)
+           "source": "index.js (3:7) @ {module evaluation}
          > 3 | throw new Error('no')
              |       ^",
            "stack": [
-             "[project]/index.js [ssr] (ecmascript) index.js (3:7)",
-             "[project]/pages/index.js [ssr] (ecmascript) <module evaluation> pages/index.js (1:1)",
-             "[project]/pages/index.js [ssr] (ecmascript) pages/index.js (1:1)",
+             "{module evaluation} index.js (3:7)",
+             "{module evaluation} pages/index.js (1:1)",
+             "{module evaluation} pages/index.js (1:1)",
              "<FIXME-next-dist-dir>",
            ],
          }

test/development/acceptance/ReactRefreshRegression.test.ts

@@ -287,8 +287,7 @@ describe('ReactRefreshRegression', () => {
          "description": "boom",
          "environmentLabel": null,
          "label": "Runtime Error",
-         "source": "pages/index.js (1:36) @
-       {default export}
+         "source": "pages/index.js (1:36) @ {default export}
        > 1 | export default function () { throw new Error('boom'); }
            |                                    ^",
          "stack": [

test/development/app-dir/ssr-in-rsc/ssr-in-rsc.test.ts

@@ -358,7 +358,7 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "Cannot read properties of undefined (reading 'ReactCurrentDispatcher')",
-            "source": "app/exports/app-code/react-dom-server-node-explicit/page.js (1:1) @ [project]/app/exports/app-code/react-dom-server-node-explicit/page.js [app-rsc] (ecmascript)
+            "source": "app/exports/app-code/react-dom-server-node-explicit/page.js (1:1) @ {module evaluation}
 
           > 1 | import * as ReactDOMServerNode from 'react-dom/server.node'
               | ^
@@ -371,7 +371,7 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "react-dom/server is not supported in React Server Components.",
-            "source": "app/exports/app-code/react-dom-server-node-explicit/page.js (1:1) @ [project]/app/exports/app-code/react-dom-server-node-explicit/page.js [app-rsc] (ecmascript)
+            "source": "app/exports/app-code/react-dom-server-node-explicit/page.js (1:1) @ {module evaluation}
 
           > 1 | import * as ReactDOMServerNode from 'react-dom/server.node'
               | ^
@@ -498,7 +498,7 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "Cannot read properties of undefined (reading 'ReactCurrentDispatcher')",
-            "source": "internal-pkg/server.node.js (1:1) @ [project]/internal-pkg/server.node.js [app-rsc] (ecmascript)
+            "source": "internal-pkg/server.node.js (1:1) @ {module evaluation}
 
           > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
               | ^
@@ -511,7 +511,7 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "react-dom/server is not supported in React Server Components.",
-            "source": "internal-pkg/server.node.js (1:1) @ [project]/internal-pkg/server.node.js [app-rsc] (ecmascript)
+            "source": "internal-pkg/server.node.js (1:1) @ {module evaluation}
 
           > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
               | ^
@@ -796,20 +796,20 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "Cannot read properties of undefined (reading 'ReactCurrentDispatcher')",
-            "source": "internal-pkg/server.node.js (1:1) @ [project]/internal-pkg/server.node.js [app-rsc] (ecmascript)
-
-          > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
-              | ^
-            2 | // Fine to drop once React is on ESM
-            3 | import ReactDOMServerEdgeDefault from 'react-dom/server.node'
-            4 |",
-          }
+            "source": "internal-pkg/server.node.js (1:1) @ {module evaluation}
+
+           > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
+               | ^
+             2 | // Fine to drop once React is on ESM
+             3 | import ReactDOMServerEdgeDefault from 'react-dom/server.node'
+             4 |",
+           }
         `)
       } else {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "react-dom/server is not supported in React Server Components.",
-            "source": "internal-pkg/server.node.js (1:1) @ [project]/internal-pkg/server.node.js [app-rsc] (ecmascript)
+            "source": "internal-pkg/server.node.js (1:1) @ {module evaluation}
 
           > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
               | ^
@@ -854,7 +854,7 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
           {
             "description": "Cannot read properties of undefined (reading 'ReactCurrentDispatcher')",
-            "source": "internal-pkg/server.node.js (1:1) @ [project]/internal-pkg/server.node.js [app-rsc] (ecmascript)
+            "source": "internal-pkg/server.node.js (1:1) @ {module evaluation}
 
           > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
               | ^
@@ -867,7 +867,7 @@ describe('react-dom/server in React Server environment', () => {
         expect(redbox).toMatchInlineSnapshot(`
          {
            "description": "react-dom/server is not supported in React Server Components.",
-           "source": "internal-pkg/server.node.js (1:1) @ [project]/internal-pkg/server.node.js [app-rsc] (ecmascript)
+           "source": "internal-pkg/server.node.js (1:1) @ {module evaluation}
 
          > 1 | import * as ReactDOMServerEdge from 'react-dom/server.node'
              | ^

test/development/middleware-errors/index.test.ts

@@ -57,8 +57,7 @@ describe('middleware - development errors', () => {
            "description": "boom",
            "environmentLabel": null,
            "label": "Runtime Error",
-           "source": "middleware.js (3:15) @
-         {default export}
+           "source": "middleware.js (3:15) @ {default export}
          > 3 |         throw new Error('boom')
              |               ^",
            "stack": [
@@ -268,7 +267,7 @@ describe('middleware - development errors', () => {
         isTurbopack
           ? '\n ⨯ Error: booooom!' +
               // TODO(veil): Should be sourcemapped
-              '\n    at [project]/middleware.js [middleware-edge] (ecmascript)'
+              '\n    at __TURBOPACK__module__evaluation__ (middleware.js:3:13)'
           : '\n ⨯ Error: booooom!' +
               // TODO: Should be anonymous method without a method name
               '\n    at <unknown> (middleware.js:3)' +
@@ -288,11 +287,11 @@ describe('middleware - development errors', () => {
            "description": "booooom!",
            "environmentLabel": null,
            "label": "Runtime Error",
-           "source": "middleware.js (3:13) @ [project]/middleware.js [middleware-edge] (ecmascript)
+           "source": "middleware.js (3:13) @ {module evaluation}
          > 3 |       throw new Error('booooom!')
              |             ^",
            "stack": [
-             "[project]/middleware.js [middleware-edge] (ecmascript) middleware.js (3:13)",
+             "{module evaluation} middleware.js (3:13)",
            ],
          }
         `)

test/development/pages-dir/client-navigation/index.test.ts

@@ -353,11 +353,11 @@ describe('Client Navigation', () => {
              "description": "An Expected error occurred",
              "environmentLabel": null,
              "label": "Runtime Error",
-             "source": "pages/error-in-the-browser-global-scope.js (2:9) @ [project]/pages/error-in-the-browser-global-scope.js [client] (ecmascript)
+             "source": "pages/error-in-the-browser-global-scope.js (2:9) @ {module evaluation}
            > 2 |   throw new Error('An Expected error occurred')
                |         ^",
              "stack": [
-               "[project]/pages/error-in-the-browser-global-scope.js [client] (ecmascript) pages/error-in-the-browser-global-scope.js (2:9)",
+               "{module evaluation} pages/error-in-the-browser-global-scope.js (2:9)",
              ],
            }
           `)

test/development/pages-dir/client-navigation/rendering.test.ts

@@ -236,8 +236,7 @@ describe('Client Navigation rendering', () => {
            "description": "This is an expected error",
            "environmentLabel": null,
            "label": "Runtime Error",
-           "source": "pages/error-inside-page.js (2:9) @
-         {default export}
+           "source": "pages/error-inside-page.js (2:9) @ {default export}
          > 2 |   throw new Error('This is an expected error')
              |         ^",
            "stack": [
@@ -274,11 +273,11 @@ describe('Client Navigation rendering', () => {
            "description": "aa is not defined",
            "environmentLabel": null,
            "label": "Runtime ReferenceError",
-           "source": "pages/error-in-the-global-scope.js (1:1) @ [project]/pages/error-in-the-global-scope.js [ssr] (ecmascript)
+           "source": "pages/error-in-the-global-scope.js (1:1) @ {module evaluation}
          > 1 | aa = 10 //eslint-disable-line
              | ^",
            "stack": [
-             "[project]/pages/error-in-the-global-scope.js [ssr] (ecmascript) pages/error-in-the-global-scope.js (1:1)",
+             "{module evaluation} pages/error-in-the-global-scope.js (1:1)",
              "<FIXME-next-dist-dir>",
            ],
          }

test/e2e/app-dir/cache-components-errors/cache-components-errors.test.ts

@@ -2425,11 +2425,11 @@ describe('Cache Components Errors', () => {
                  "description": ""use cache: private" must not be used within \`unstable_cache()\`.",
                  "environmentLabel": null,
                  "label": "Runtime Error",
-                 "source": "app/use-cache-private-in-unstable-cache/page.tsx (21:38) @ [project]/app/use-cache-private-in-unstable-cache/page.tsx [app-rsc] (ecmascript)
+                 "source": "app/use-cache-private-in-unstable-cache/page.tsx (21:38) @ {module evaluation}
                > 21 | const getCachedData = unstable_cache(async () => {
                     |                                      ^",
                  "stack": [
-                   "[project]/app/use-cache-private-in-unstable-cache/page.tsx [app-rsc] (ecmascript) app/use-cache-private-in-unstable-cache/page.tsx (21:38)",
+                   "{module evaluation} app/use-cache-private-in-unstable-cache/page.tsx (21:38)",
                    "<FIXME-file-protocol>",
                    "<FIXME-file-protocol>",
                    "<FIXME-next-dist-dir>",
@@ -2486,7 +2486,7 @@ describe('Cache Components Errors', () => {
               if (isDebugPrerender) {
                 expect(output).toMatchInlineSnapshot(`
                  "Error: "use cache: private" must not be used within \`unstable_cache()\`.
-                     at 0 (bundler:///app/use-cache-private-in-unstable-cache/page.tsx:21:38)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-unstable-cache/page.tsx:21:38)
                      at a (<next-dist-dir>)
                      at b (<next-dist-dir>)
                    19 | }
@@ -2505,7 +2505,7 @@ describe('Cache Components Errors', () => {
               } else {
                 expect(output).toMatchInlineSnapshot(`
                  "Error: "use cache: private" must not be used within \`unstable_cache()\`.
-                     at 0 (bundler:///app/use-cache-private-in-unstable-cache/page.tsx:21:38)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-unstable-cache/page.tsx:21:38)
                      at a (<next-dist-dir>)
                    19 | }
                    20 |
@@ -2569,11 +2569,11 @@ describe('Cache Components Errors', () => {
                  "description": ""use cache: private" must not be used within "use cache". It can only be nested inside of another "use cache: private".",
                  "environmentLabel": null,
                  "label": "Runtime Error",
-                 "source": "app/use-cache-private-in-use-cache/page.tsx (15:1) @ [project]/app/use-cache-private-in-use-cache/page.tsx [app-rsc] (ecmascript)
+                 "source": "app/use-cache-private-in-use-cache/page.tsx (15:1) @ {module evaluation}
                > 15 | async function Private() {
                     | ^",
                  "stack": [
-                   "[project]/app/use-cache-private-in-use-cache/page.tsx [app-rsc] (ecmascript) app/use-cache-private-in-use-cache/page.tsx (15:1)",
+                   "{module evaluation} app/use-cache-private-in-use-cache/page.tsx (15:1)",
                    "<FIXME-file-protocol>",
                    "<FIXME-file-protocol>",
                    "<FIXME-next-dist-dir>",
@@ -2631,7 +2631,7 @@ describe('Cache Components Errors', () => {
               if (isDebugPrerender) {
                 expect(output).toMatchInlineSnapshot(`
                  "Error: "use cache: private" must not be used within "use cache". It can only be nested inside of another "use cache: private".
-                     at 0 (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
                      at a (<next-dist-dir>)
                      at b (<next-dist-dir>)
                    13 | }
@@ -2642,7 +2642,7 @@ describe('Cache Components Errors', () => {
                    17 |
                    18 |   return <p>Private</p>
                  Error: "use cache: private" must not be used within "use cache". It can only be nested inside of another "use cache: private".
-                     at 1 (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
                      at c (<next-dist-dir>)
                      at d (<next-dist-dir>)
                    13 | }
@@ -2661,8 +2661,8 @@ describe('Cache Components Errors', () => {
               } else {
                 expect(output).toMatchInlineSnapshot(`
                  "Error: "use cache: private" must not be used within "use cache". It can only be nested inside of another "use cache: private".
-                     at 0 (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
-                     at 1 (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:16)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:16)
                      at a (<next-dist-dir>)
                    13 | }
                    14 |
@@ -2672,8 +2672,8 @@ describe('Cache Components Errors', () => {
                    17 |
                    18 |   return <p>Private</p>
                  Error: "use cache: private" must not be used within "use cache". It can only be nested inside of another "use cache: private".
-                     at 2 (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
-                     at 3 (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:16)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:1)
+                     at __TURBOPACK__module__evaluation__ (bundler:///app/use-cache-private-in-use-cache/page.tsx:15:16)
                      at b (<next-dist-dir>)
                    13 | }
                    14 |