Skip to content

Commit a65efcb

Browse files
authored
chore: page.close -> Close page in steps (microsoft#36834)
Signed-off-by: Max Schmitt <[email protected]>
1 parent 93d2b4b commit a65efcb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/playwright-core/src/utils/isomorphic/protocolMetainfo.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export const methodMetainfo = new Map<string, { internal?: boolean, title?: stri
9898
['BrowserContext.clockSetFixedTime', { title: 'Set fixed time "{timeNumber}{timeString}"', }],
9999
['BrowserContext.clockSetSystemTime', { title: 'Set system time "{timeNumber}{timeString}"', }],
100100
['Page.addInitScript', { }],
101-
['Page.close', { title: 'Close', }],
101+
['Page.close', { title: 'Close page', }],
102102
['Page.emulateMedia', { title: 'Emulate media', snapshot: true, }],
103103
['Page.exposeBinding', { title: 'Expose binding', }],
104104
['Page.goBack', { title: 'Go back', slowMo: true, snapshot: true, }],

packages/protocol/src/protocol.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1554,7 +1554,7 @@ Page:
15541554
source: string
15551555

15561556
close:
1557-
title: Close
1557+
title: Close page
15581558
parameters:
15591559
runBeforeUnload: boolean?
15601560
reason: string?

tests/library/tracing.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ test('should collect trace with resources, but no js', async ({ context, page, s
5252
'Navigate to "/input/fileupload.html"',
5353
'Set input files',
5454
'Wait for timeout',
55-
'Close',
55+
'Close page',
5656
]);
5757

5858
expect(events.some(e => e.type === 'frame-snapshot')).toBeTruthy();
@@ -200,7 +200,7 @@ test('should collect two traces', async ({ context, page, server }, testInfo) =>
200200
expect(events[0].type).toBe('context-options');
201201
expect(actions).toEqual([
202202
'Double click',
203-
'Close',
203+
'Close page',
204204
]);
205205
}
206206
});

0 commit comments

Comments
 (0)