Skip to content

Commit a6cb009

Browse files
authored
fix(ui-mode): don't rerender trace snapshots on long running actions (microsoft#36677)
1 parent 3d82bec commit a6cb009

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

packages/trace-viewer/src/ui/snapshotTab.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,13 @@ export const SnapshotTabsView: React.FunctionComponent<{
5656
const snapshots = React.useMemo(() => {
5757
return collectSnapshots(action);
5858
}, [action]);
59-
const snapshotUrls = React.useMemo(() => {
59+
const { snapshotInfoUrl, snapshotUrl, popoutUrl } = React.useMemo(() => {
6060
const snapshot = snapshots[snapshotTab];
61-
return snapshot ? extendSnapshot(snapshot, shouldPopulateCanvasFromScreenshot) : undefined;
61+
return snapshot ? extendSnapshot(snapshot, shouldPopulateCanvasFromScreenshot) : { snapshotInfoUrl: undefined, snapshotUrl: undefined, popoutUrl: undefined };
6262
}, [snapshots, snapshotTab, shouldPopulateCanvasFromScreenshot]);
6363

64+
const snapshotUrls = React.useMemo((): SnapshotUrls | undefined => snapshotInfoUrl !== undefined ? { snapshotInfoUrl, snapshotUrl, popoutUrl } : undefined, [snapshotInfoUrl, snapshotUrl, popoutUrl]);
65+
6466
return <div className='snapshot-tab vbox'>
6567
<Toolbar>
6668
<ToolbarButton className='pick-locator' title='Pick locator' icon='target' toggled={isInspecting} onClick={() => setIsInspecting(!isInspecting)} />

0 commit comments

Comments
 (0)