fix(storageState): enhance error handling for storage state setting (microsoft#36781)

Author: mxschmitt

packages/playwright-core/src/server/browserContext.ts

@@ -25,6 +25,7 @@ import { Debugger } from './debugger';
 import { DialogManager } from './dialog';
 import { BrowserContextAPIRequestContext } from './fetch';
 import { mkdirIfNeeded } from './utils/fileUtils';
+import { rewriteErrorMessage } from '../utils/isomorphic/stackTrace';
 import { HarRecorder } from './har/harRecorder';
 import { helper } from './helper';
 import { SdkObject } from './instrumentation';
@@ -644,6 +645,9 @@ export abstract class BrowserContext extends SdkObject {
         }
         await page.close();
       }
+    } catch (error) {
+      rewriteErrorMessage(error, `Error setting storage state:\n` + error.message);
+      throw error;
     } finally {
       this._settingStorageState = false;
     }

tests/library/browsercontext-storage-state.spec.ts

@@ -74,6 +74,25 @@ it('should set local storage', async ({ contextFactory }) => {
   await context.close();
 });
 
+it('should report good error if the url is not valid', async ({ contextFactory }) => {
+  const error = await contextFactory({
+    storageState: {
+      cookies: [],
+      origins: [
+        {
+          origin: 'foo',
+          localStorage: [{
+            name: 'name1',
+            value: 'value1'
+          }]
+        },
+      ]
+    }
+  }).catch(e => e);
+  expect(error.message).toContain('browser.newContext: Error setting storage state:');
+  expect(error.message).toContain('foo');
+});
+
 it('should round-trip through the file', async ({ contextFactory }, testInfo) => {
   const context = await contextFactory();
   const page1 = await context.newPage();