Address PR comments

Author: kiridi

csharp/ql/src/semmle/code/csharp/ir/implementation/raw/internal/TranslatedElement.qll

@@ -205,6 +205,10 @@ private predicate ignoreLoad(Expr expr) {
   // to get the address of the first element in an array
   expr = any(ArrayAccess aa).getQualifier()
   or
+  // Indexer calls returns a reference or a value,
+  // no need to load it
+  expr instanceof IndexerCall
+  or
   // No load is needed for the lvalue in an assignment such as:
   // Eg. `Object obj = oldObj`;
   expr = any(Assignment a).getLValue() and

csharp/ql/test/library-tests/ir/ir/events.cs

@@ -1,19 +1,35 @@
 class Events
 {
     public delegate string MyDel(string str);
+    public MyDel Inst;
 
     event MyDel MyEvent;
 
-    public Events() {
-        this.MyEvent += new MyDel(this.WelcomeUser);
+    public Events()
+    {
+        this.Inst = new MyDel(this.Fun);
     }
 
-    public string WelcomeUser(string username) {
-        return "Welcome " + username;
+    public void AddEvent() 
+    {
+        this.MyEvent += this.Inst;
+    }
+
+    public void RemoveEvent()
+    {
+        this.MyEvent -= this.Inst;
+    }
+
+    public string Fun(string str) 
+    {
+        return str;
     }
 
-    static void Main(string[] args) {
-        Events obj1 = new Events();
-        string result = obj1.MyEvent("Tutorials Point");
+    static void Main(string[] args) 
+    {
+        Events obj = new Events();
+        obj.AddEvent();
+        string result = obj.MyEvent("string");
+        obj.RemoveEvent();
     }
 }

csharp/ql/test/library-tests/ir/ir/indexers.cs

@@ -1,8 +1,12 @@
 class Indexers
 {
-    public class Contact
+    public class MyClass
     {
-        private string[] address = new string[3];
+        public MyClass()
+        {
+        }
+
+        private string[] address = new string[2];
         public string this[int index]
         {
             get
@@ -18,9 +22,9 @@ public string this[int index]
 
     public static void Main()
     {
-        Contact contact = new Contact();
-        contact[0] = "Begumpet";
-        contact[1] = "Hyderabad";
-        contact[2] = "Telengana";
+        MyClass inst = new MyClass();
+        inst[0] = "str1";
+        inst[1] = "str1";
+        inst[1] = inst[0];
     }
 }