Skip to content

Commit 2e39251

Browse files
geoffw0Dave Bartolomeo
andauthored
Apply suggestions from code review
Co-Authored-By: Dave Bartolomeo <[email protected]>
1 parent a7c22db commit 2e39251

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cpp/ql/src/semmle/code/cpp/rangeanalysis/SimpleRangeAnalysis.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ private class UnsignedBitwiseAndExpr extends BitwiseAndExpr {
126126
UnsignedBitwiseAndExpr() {
127127
(
128128
getLeftOperand().getFullyConverted().getType().getUnderlyingType().(IntegralType).isUnsigned() or
129-
getLeftOperand().getValue().toInt() >= 0
129+
getLeftOperand().getFullyConverted().getValue().toInt() >= 0
130130
) and
131131
(
132132
getRightOperand()
@@ -135,7 +135,7 @@ private class UnsignedBitwiseAndExpr extends BitwiseAndExpr {
135135
.getUnderlyingType()
136136
.(IntegralType)
137137
.isUnsigned() or
138-
getRightOperand().getValue().toInt() >= 0
138+
getRightOperand().getFullyConverted().getValue().toInt() >= 0
139139
)
140140
}
141141
}

0 commit comments

Comments
 (0)