Merge pull request github#3234 from RasmusWL/python-modenise-files

semmle-qlci · web-flow · commit 2e95cab970e6 · 2020-04-14T10:38:26.000+01:00
Approved by BekaValentine
diff --git a/python/ql/src/semmle/python/dataflow/Files.qll b/python/ql/src/semmle/python/dataflow/Files.qll
@@ -11,7 +11,7 @@ class OpenFileConfiguration extends TaintTracking::Configuration {
     OpenFileConfiguration() { this = "Open file configuration" }
 
     override predicate isSource(DataFlow::Node src, TaintKind kind) {
-        theOpenFunction().(FunctionObject).getACall() = src.asCfgNode() and
+        src.asCfgNode() = Value::named("open").getACall() and
         kind instanceof OpenFile
     }
 

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class OpenFileConfiguration extends TaintTracking::Configuration {`
`11`	`11`	`OpenFileConfiguration() { this = "Open file configuration" }`
`12`	`12`
`13`	`13`	`override predicate isSource(DataFlow::Node src, TaintKind kind) {`
`14`		`- theOpenFunction().(FunctionObject).getACall() = src.asCfgNode() and`
	`14`	`+ src.asCfgNode() = Value::named("open").getACall() and`
`15`	`15`	`kind instanceof OpenFile`
`16`	`16`	`}`
`17`	`17`