Skip to content

Commit 6318cc9

Browse files
committed
Java: Update expected test output
1 parent 09e4e79 commit 6318cc9

File tree

7 files changed

+55
-175
lines changed

7 files changed

+55
-175
lines changed
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
edges
22
| ResponseSplitting.java:22:39:22:66 | getParameter(...) [ : String] | ResponseSplitting.java:23:23:23:28 | cookie |
3-
| ResponseSplitting.java:28:38:28:72 | getParameter(...) [ : String] | ResponseSplitting.java:28:38:28:72 | getParameter(...) |
4-
| ResponseSplitting.java:29:38:29:72 | getParameter(...) [ : String] | ResponseSplitting.java:29:38:29:72 | getParameter(...) |
53
nodes
64
| ResponseSplitting.java:22:39:22:66 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
75
| ResponseSplitting.java:23:23:23:28 | cookie | semmle.label | cookie |
86
| ResponseSplitting.java:28:38:28:72 | getParameter(...) | semmle.label | getParameter(...) |
9-
| ResponseSplitting.java:28:38:28:72 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
107
| ResponseSplitting.java:29:38:29:72 | getParameter(...) | semmle.label | getParameter(...) |
11-
| ResponseSplitting.java:29:38:29:72 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
128
#select
139
| ResponseSplitting.java:23:23:23:28 | cookie | ResponseSplitting.java:22:39:22:66 | getParameter(...) [ : String] | ResponseSplitting.java:23:23:23:28 | cookie | Response-splitting vulnerability due to this $@. | ResponseSplitting.java:22:39:22:66 | getParameter(...) | user-provided value |
14-
| ResponseSplitting.java:28:38:28:72 | getParameter(...) | ResponseSplitting.java:28:38:28:72 | getParameter(...) [ : String] | ResponseSplitting.java:28:38:28:72 | getParameter(...) | Response-splitting vulnerability due to this $@. | ResponseSplitting.java:28:38:28:72 | getParameter(...) | user-provided value |
15-
| ResponseSplitting.java:29:38:29:72 | getParameter(...) | ResponseSplitting.java:29:38:29:72 | getParameter(...) [ : String] | ResponseSplitting.java:29:38:29:72 | getParameter(...) | Response-splitting vulnerability due to this $@. | ResponseSplitting.java:29:38:29:72 | getParameter(...) | user-provided value |
10+
| ResponseSplitting.java:28:38:28:72 | getParameter(...) | ResponseSplitting.java:28:38:28:72 | getParameter(...) | ResponseSplitting.java:28:38:28:72 | getParameter(...) | Response-splitting vulnerability due to this $@. | ResponseSplitting.java:28:38:28:72 | getParameter(...) | user-provided value |
11+
| ResponseSplitting.java:29:38:29:72 | getParameter(...) | ResponseSplitting.java:29:38:29:72 | getParameter(...) | ResponseSplitting.java:29:38:29:72 | getParameter(...) | Response-splitting vulnerability due to this $@. | ResponseSplitting.java:29:38:29:72 | getParameter(...) | user-provided value |

java/ql/test/query-tests/security/CWE-129/semmle/tests/ImproperValidationOfArrayIndexCodeSpecified.expected

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,18 @@ edges
22
| Test.java:40:17:40:48 | nextInt(...) [ : Number] | Test.java:43:30:43:34 | index |
33
| Test.java:40:17:40:48 | nextInt(...) [ : Number] | Test.java:47:32:47:36 | index |
44
| Test.java:40:17:40:48 | nextInt(...) [ : Number] | Test.java:51:39:51:43 | index |
5-
| Test.java:64:34:64:34 | 0 [ : Number] | Test.java:64:34:64:34 | 0 |
6-
| Test.java:70:37:70:37 | 0 [ : Number] | Test.java:70:37:70:37 | 0 |
7-
| Test.java:77:39:77:39 | 0 [ : Number] | Test.java:77:39:77:39 | 0 |
8-
| Test.java:91:30:91:30 | 0 [ : Number] | Test.java:91:30:91:30 | 0 |
95
| Test.java:93:17:93:17 | 0 [ : Number] | Test.java:96:32:96:36 | index |
10-
| Test.java:102:30:102:30 | 0 [ : Number] | Test.java:102:30:102:30 | 0 |
116
nodes
127
| Test.java:40:17:40:48 | nextInt(...) [ : Number] | semmle.label | nextInt(...) [ : Number] |
138
| Test.java:43:30:43:34 | index | semmle.label | index |
149
| Test.java:47:32:47:36 | index | semmle.label | index |
1510
| Test.java:51:39:51:43 | index | semmle.label | index |
1611
| Test.java:64:34:64:34 | 0 | semmle.label | 0 |
17-
| Test.java:64:34:64:34 | 0 [ : Number] | semmle.label | 0 [ : Number] |
1812
| Test.java:70:37:70:37 | 0 | semmle.label | 0 |
19-
| Test.java:70:37:70:37 | 0 [ : Number] | semmle.label | 0 [ : Number] |
2013
| Test.java:77:39:77:39 | 0 | semmle.label | 0 |
21-
| Test.java:77:39:77:39 | 0 [ : Number] | semmle.label | 0 [ : Number] |
2214
| Test.java:91:30:91:30 | 0 | semmle.label | 0 |
23-
| Test.java:91:30:91:30 | 0 [ : Number] | semmle.label | 0 [ : Number] |
2415
| Test.java:93:17:93:17 | 0 [ : Number] | semmle.label | 0 [ : Number] |
2516
| Test.java:96:32:96:36 | index | semmle.label | index |
2617
| Test.java:102:30:102:30 | 0 | semmle.label | 0 |
27-
| Test.java:102:30:102:30 | 0 [ : Number] | semmle.label | 0 [ : Number] |
2818
#select
2919
| Test.java:43:30:43:34 | index | Test.java:40:17:40:48 | nextInt(...) [ : Number] | Test.java:43:30:43:34 | index | $@ flows to the index used in this array access, and may cause the operation to throw an ArrayIndexOutOfBoundsException. | Test.java:40:17:40:48 | nextInt(...) | Random value |
Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
edges
2-
| Test.java:19:45:19:49 | "DES" [ : String] | Test.java:19:45:19:49 | "DES" |
3-
| Test.java:42:33:42:37 | "RC2" [ : String] | Test.java:42:33:42:37 | "RC2" |
42
nodes
53
| Test.java:19:45:19:49 | "DES" | semmle.label | "DES" |
6-
| Test.java:19:45:19:49 | "DES" [ : String] | semmle.label | "DES" [ : String] |
74
| Test.java:42:33:42:37 | "RC2" | semmle.label | "RC2" |
8-
| Test.java:42:33:42:37 | "RC2" [ : String] | semmle.label | "RC2" [ : String] |
95
#select
10-
| Test.java:19:20:19:50 | getInstance(...) | Test.java:19:45:19:49 | "DES" [ : String] | Test.java:19:45:19:49 | "DES" | Cryptographic algorithm $@ is weak and should not be used. | Test.java:19:45:19:49 | "DES" | "DES" |
11-
| Test.java:42:14:42:38 | getInstance(...) | Test.java:42:33:42:37 | "RC2" [ : String] | Test.java:42:33:42:37 | "RC2" | Cryptographic algorithm $@ is weak and should not be used. | Test.java:42:33:42:37 | "RC2" | "RC2" |
6+
| Test.java:19:20:19:50 | getInstance(...) | Test.java:19:45:19:49 | "DES" | Test.java:19:45:19:49 | "DES" | Cryptographic algorithm $@ is weak and should not be used. | Test.java:19:45:19:49 | "DES" | "DES" |
7+
| Test.java:42:14:42:38 | getInstance(...) | Test.java:42:33:42:37 | "RC2" | Test.java:42:33:42:37 | "RC2" | Cryptographic algorithm $@ is weak and should not be used. | Test.java:42:33:42:37 | "RC2" | "RC2" |
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
edges
2-
| Test.java:34:48:34:52 | "foo" [ : String] | Test.java:34:48:34:52 | "foo" |
32
nodes
43
| Test.java:34:48:34:52 | "foo" | semmle.label | "foo" |
5-
| Test.java:34:48:34:52 | "foo" [ : String] | semmle.label | "foo" [ : String] |
64
#select
7-
| Test.java:34:21:34:53 | new SecretKeySpec(...) | Test.java:34:48:34:52 | "foo" [ : String] | Test.java:34:48:34:52 | "foo" | Cryptographic algorithm $@ may not be secure, consider using a different algorithm. | Test.java:34:48:34:52 | "foo" | "foo" |
5+
| Test.java:34:21:34:53 | new SecretKeySpec(...) | Test.java:34:48:34:52 | "foo" | Test.java:34:48:34:52 | "foo" | Cryptographic algorithm $@ may not be secure, consider using a different algorithm. | Test.java:34:48:34:52 | "foo" | "foo" |
Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,13 @@
11
edges
2-
| UrlRedirect.java:23:25:23:54 | getParameter(...) [ : String] | UrlRedirect.java:23:25:23:54 | getParameter(...) |
32
| UrlRedirect.java:36:58:36:89 | getParameter(...) [ : String] | UrlRedirect.java:36:25:36:89 | ... + ... |
4-
| UrlRedirect.java:39:34:39:63 | getParameter(...) [ : String] | UrlRedirect.java:39:34:39:63 | getParameter(...) |
5-
| UrlRedirect.java:42:43:42:72 | getParameter(...) [ : String] | UrlRedirect.java:42:43:42:72 | getParameter(...) |
63
nodes
74
| UrlRedirect.java:23:25:23:54 | getParameter(...) | semmle.label | getParameter(...) |
8-
| UrlRedirect.java:23:25:23:54 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
95
| UrlRedirect.java:36:25:36:89 | ... + ... | semmle.label | ... + ... |
106
| UrlRedirect.java:36:58:36:89 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
117
| UrlRedirect.java:39:34:39:63 | getParameter(...) | semmle.label | getParameter(...) |
12-
| UrlRedirect.java:39:34:39:63 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
138
| UrlRedirect.java:42:43:42:72 | getParameter(...) | semmle.label | getParameter(...) |
14-
| UrlRedirect.java:42:43:42:72 | getParameter(...) [ : String] | semmle.label | getParameter(...) [ : String] |
159
#select
16-
| UrlRedirect.java:23:25:23:54 | getParameter(...) | UrlRedirect.java:23:25:23:54 | getParameter(...) [ : String] | UrlRedirect.java:23:25:23:54 | getParameter(...) | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:23:25:23:54 | getParameter(...) | user-provided value |
10+
| UrlRedirect.java:23:25:23:54 | getParameter(...) | UrlRedirect.java:23:25:23:54 | getParameter(...) | UrlRedirect.java:23:25:23:54 | getParameter(...) | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:23:25:23:54 | getParameter(...) | user-provided value |
1711
| UrlRedirect.java:36:25:36:89 | ... + ... | UrlRedirect.java:36:58:36:89 | getParameter(...) [ : String] | UrlRedirect.java:36:25:36:89 | ... + ... | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:36:58:36:89 | getParameter(...) | user-provided value |
18-
| UrlRedirect.java:39:34:39:63 | getParameter(...) | UrlRedirect.java:39:34:39:63 | getParameter(...) [ : String] | UrlRedirect.java:39:34:39:63 | getParameter(...) | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:39:34:39:63 | getParameter(...) | user-provided value |
19-
| UrlRedirect.java:42:43:42:72 | getParameter(...) | UrlRedirect.java:42:43:42:72 | getParameter(...) [ : String] | UrlRedirect.java:42:43:42:72 | getParameter(...) | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:42:43:42:72 | getParameter(...) | user-provided value |
12+
| UrlRedirect.java:39:34:39:63 | getParameter(...) | UrlRedirect.java:39:34:39:63 | getParameter(...) | UrlRedirect.java:39:34:39:63 | getParameter(...) | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:39:34:39:63 | getParameter(...) | user-provided value |
13+
| UrlRedirect.java:42:43:42:72 | getParameter(...) | UrlRedirect.java:42:43:42:72 | getParameter(...) | UrlRedirect.java:42:43:42:72 | getParameter(...) | Potentially untrusted URL redirection due to $@. | UrlRedirect.java:42:43:42:72 | getParameter(...) | user-provided value |

0 commit comments

Comments
 (0)