Merge pull request github#1309 from hvitved/csharp/get-explicit-arg-nomagic

calumgrant · web-flow · commit 6994ba904bad · 2019-05-16T10:57:00.000+01:00
Add `pragma[nomagic]` to `getExplicitArgument()`
diff --git a/csharp/ql/src/semmle/code/csharp/exprs/Call.qll b/csharp/ql/src/semmle/code/csharp/exprs/Call.qll
@@ -108,15 +108,13 @@ class Call extends DotNet::Call, Expr, @call {
     )
   }
 
-  // predicate folding to get proper join-order
   pragma[noinline]
   private Expr getImplicitArgument(int pos) {
     result = getArgument(pos) and
     not exists(result.getExplicitArgumentName())
   }
 
-  // predicate folding to get proper join-order
-  pragma[noinline]
+  pragma[nomagic]
   private Expr getExplicitArgument(string name) {
     result = getAnArgument() and
     result.getExplicitArgumentName() = name

Original file line number	Diff line number	Diff line change
`@@ -108,15 +108,13 @@ class Call extends DotNet::Call, Expr, @call {`
`108`	`108`	`)`
`109`	`109`	`}`
`110`	`110`
`111`		`- // predicate folding to get proper join-order`
`112`	`111`	`pragma[noinline]`
`113`	`112`	`private Expr getImplicitArgument(int pos) {`
`114`	`113`	`result = getArgument(pos) and`
`115`	`114`	`not exists(result.getExplicitArgumentName())`
`116`	`115`	`}`
`117`	`116`
`118`		`- // predicate folding to get proper join-order`
`119`		`- pragma[noinline]`
	`117`	`+ pragma[nomagic]`
`120`	`118`	`private Expr getExplicitArgument(string name) {`
`121`	`119`	`result = getAnArgument() and`
`122`	`120`	`result.getExplicitArgumentName() = name`