Skip to content

Commit 7071692

Browse files
C++: Clarify comment based on PR feedback
1 parent 34a422c commit 7071692

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

cpp/ql/src/semmle/code/cpp/ir/implementation/aliased_ssa/internal/SSAConstruction.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -647,6 +647,8 @@ module DefUse {
647647
/**
648648
* Holds if the specified `useLocation` is live on entry to `block`. This holds if there is a use of `useLocation`
649649
* that is reachable from the start of `block` without passing through a definition that overlaps `useLocation`.
650+
* Note that even a partially-overlapping definition blocks liveness, because such a definition will insert a `Chi`
651+
* instruction whose result totally overlaps the ___location.
650652
*/
651653
predicate locationLiveOnEntryToBlock(Alias::MemoryLocation useLocation, OldBlock block) {
652654
definitionHasPhiNode(useLocation, block) or

cpp/ql/src/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/SSAConstruction.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -647,6 +647,8 @@ module DefUse {
647647
/**
648648
* Holds if the specified `useLocation` is live on entry to `block`. This holds if there is a use of `useLocation`
649649
* that is reachable from the start of `block` without passing through a definition that overlaps `useLocation`.
650+
* Note that even a partially-overlapping definition blocks liveness, because such a definition will insert a `Chi`
651+
* instruction whose result totally overlaps the ___location.
650652
*/
651653
predicate locationLiveOnEntryToBlock(Alias::MemoryLocation useLocation, OldBlock block) {
652654
definitionHasPhiNode(useLocation, block) or

0 commit comments

Comments
 (0)