C++: mustwrite = false.

geoffw0 · geoffw0 · commit 9e117709bcc8 · 2020-03-20T14:59:57.000Z
diff --git a/cpp/ql/src/semmle/code/cpp/models/implementations/Strcpy.qll b/cpp/ql/src/semmle/code/cpp/models/implementations/Strcpy.qll
@@ -83,7 +83,7 @@ class StrcpyFunction extends ArrayFunction, DataFlowFunction, TaintFunction, Sid
   override predicate hasSpecificWriteSideEffect(ParameterIndex i, boolean buffer, boolean mustWrite) {
     i = 0 and
     buffer = true and
-    mustWrite = true
+    mustWrite = false
   }
 
   override predicate hasSpecificReadSideEffect(ParameterIndex i, boolean buffer) {

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ class StrcpyFunction extends ArrayFunction, DataFlowFunction, TaintFunction, Sid`
`83`	`83`	`override predicate hasSpecificWriteSideEffect(ParameterIndex i, boolean buffer, boolean mustWrite) {`
`84`	`84`	`i = 0 and`
`85`	`85`	`buffer = true and`
`86`		`- mustWrite = true`
	`86`	`+ mustWrite = false`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`override predicate hasSpecificReadSideEffect(ParameterIndex i, boolean buffer) {`