Merge pull request #9 from 42races/remove_httparty

Remove httparty gem, use Net:HTTP standard library

Author: deepakkumarnd

lib/open_weather/base.rb

@@ -1,5 +1,5 @@
-require 'httparty'
-require 'addressable/uri'
+require 'net/http'
+require 'json'
 
 module OpenWeather
   class Base
@@ -37,16 +37,16 @@ def extract_options!(options)
     end
 
     def parse_response
-      @weather_info = @response
+      @weather_info = JSON.parse(@response)
       @status = @weather_info["cod"]
       @message = @weather_info["message"] unless @status
       @weather_info
     end
 
     def send_request(request)
-      uri = Addressable::URI.parse(request.url)
-      uri.query_values = request.options
-      HTTParty.get(uri.to_s)
+      uri = URI(request.url)
+      uri.query = URI.encode_www_form(request.options)
+      Net::HTTP.get(uri)
     end
   end
 end

open_weather.gemspec

@@ -14,7 +14,5 @@ Gem::Specification.new do |gem|
   gem.executables          = gem.files.grep(/^bin/).map{ |f| File.basename(f) }
   gem.require_paths        = ["lib"]
   gem.add_development_dependency "rspec"
-
-  gem.add_runtime_dependency 'httparty'
-  gem.add_runtime_dependency 'addressable'
+  gem.add_runtime_dependency 'json'
 end

spec/open_weather/api_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 # success response
-# 
+#
 # {"coord"=>{"lon"=>76.26, "lat"=>9.94},
 #  "sys"=>
 #   {"message"=>0.1938,
@@ -31,14 +31,6 @@
 #
 # {"message"=>"Error: Not found city", "cod"=>"404"}
 
-describe 'Connection Error' do
-  it 'return error when the network is unreachable' do
-      response = OpenWeather::Current.city('Cochin, In')
-      response['cod'].should eq(200)
-  end
-end
-
-
 describe 'Open weather Current API' do
   context '.city' do
     it 'return current weather for cochi' do