Merge pull request #3 from 42races/current_weather

get current weather info by city, city id or latitude and longitude

Author: coderhs

lib/open_weather_api/base.rb

@@ -2,10 +2,10 @@
 require 'addressable/uri'
 module OpenWeather
   class Base
-    def self.send_request hash, url
-      uri = Addressable::URI.parse(url)
-      uri.query_values = hash
+    def self.send_request(request)
+      uri = Addressable::URI.parse(request.url)
+      uri.query_values = request.options
       HTTParty.get(uri.to_s)
     end
   end
-end
+end

lib/open_weather_api/current_weather.rb

@@ -1,13 +1,45 @@
 module OpenWeather
   class Current < Base
+    attr_reader :url, :options, :weather_info, :status, :message
 
-    @api_url = 'http://api.openweathermap.org/data/2.5/weather'
-    
-    #format : Cochin,IN
-    def self.city(city, options = { })
-      query = Hash.new 
-      query[:q] = city
-      send_request query.merge!(options), @api_url
+    def initialize(options = {})
+      @status = false
+      @url = "http://api.openweathermap.org/data/2.5/weather"
+      @options = extract_options!(options)
+    end
+
+    def retrive
+      @response = Base.public_send(:send_request, self) unless @options.empty?
+      parse_response if @response
+    end
+
+    def success?
+      @status == 200
+    end
+
+    private
+
+    def extract_options!(options)
+      valid_options = [:lat, :lon, :city, :country, :city_id]
+      options.keys.each { |k| options.delete(k) unless valid_options.include?(k) }
+      if options[:city] || options[:country]
+        options[:q] = "#{options[:country]},#{options[:city]}"
+        options.delete(:city)
+        options.delete(:country)
+      end
+
+      if options[:city_id]
+        options[:id] = options[:city_id]
+        options.delete(:city_id)
+      end
+      options
+    end
+
+    def parse_response
+      @weather_info = @response.to_h
+      @status = @weather_info["cod"]
+      @message = @weather_info["message"] unless @status
+      @weather_info
     end
   end
 end

spec/ruby_weather_api/current_weather_spec.rb

@@ -0,0 +1,33 @@
+require "spec_helper"
+
+describe "Current Weather Info" do
+  context "Blank request" do
+    before { @api = OpenWeather::Current.new }
+
+    it "has the version 2.5 api url" do
+      @api.url.should eq("http://api.openweathermap.org/data/2.5/weather")
+    end
+
+    it "wont't send request if the options are empty" do
+      @api.retrive.should be_nil
+    end
+  end
+
+  context "Request with proper options" do
+    before { @api = OpenWeather::Current.new(city: "Kochi", country: "India") }
+
+    it "retirves the weather info" do
+      @api.retrive
+      @api.success?.should be_true
+    end
+  end
+
+  context "Request with wrong options" do
+    before { @api = OpenWeather::Current.new(city: "Kochiiiiii", country: "India") }
+
+    it "retirves the weather info" do
+      @api.retrive
+      @api.success?.should be_false
+    end
+  end
+end