Skip to content

Commit d44ed28

Browse files
committed
[CMake] Remove target to build native tablegen
This was once needed so that multiple tablegen binaries don't compile the library concurrently. However, this isn't needed anymore since adding USES_TERMINAL to the custom_command. This is supported by the fact that the target was only building LLVMSupport since some cleanups a year ago. If this dependency had really been needed, we would have seen complaints. Differential Revision: https://reviews.llvm.org/D39299 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@317695 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 41dfa19 commit d44ed28

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

cmake/modules/TableGen.cmake

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -110,19 +110,6 @@ function(add_public_tablegen_target target)
110110
set(LLVM_COMMON_DEPENDS ${LLVM_COMMON_DEPENDS} ${target} PARENT_SCOPE)
111111
endfunction()
112112

113-
if(LLVM_USE_HOST_TOOLS AND NOT TARGET NATIVE_LIB_LLVMTABLEGEN)
114-
llvm_ExternalProject_BuildCmd(tblgen_build_cmd LLVMSupport
115-
${LLVM_NATIVE_BUILD}
116-
CONFIGURATION Release)
117-
add_custom_command(OUTPUT LIB_LLVMTABLEGEN
118-
COMMAND ${tblgen_build_cmd}
119-
DEPENDS CONFIGURE_LLVM_NATIVE
120-
WORKING_DIRECTORY ${LLVM_NATIVE_BUILD}
121-
COMMENT "Building libLLVMTableGen for native TableGen..."
122-
USES_TERMINAL)
123-
add_custom_target(NATIVE_LIB_LLVMTABLEGEN DEPENDS LIB_LLVMTABLEGEN)
124-
endif()
125-
126113
macro(add_tablegen target project)
127114
set(${target}_OLD_LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS})
128115
set(LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS} TableGen)
@@ -166,7 +153,7 @@ macro(add_tablegen target project)
166153
CONFIGURATION Release)
167154
add_custom_command(OUTPUT ${${project}_TABLEGEN_EXE}
168155
COMMAND ${tblgen_build_cmd}
169-
DEPENDS ${target} NATIVE_LIB_LLVMTABLEGEN
156+
DEPENDS CONFIGURE_LLVM_NATIVE ${target}
170157
WORKING_DIRECTORY ${LLVM_NATIVE_BUILD}
171158
COMMENT "Building native TableGen..."
172159
USES_TERMINAL)

0 commit comments

Comments
 (0)