Skip to content

Commit 052f80e

Browse files
authored
Merge pull request #133 from corgicode/feature/132-back-button-bug
update routes and fix issue with the back button not re-rendering
2 parents 2b997e0 + 4f932a1 commit 052f80e

File tree

2 files changed

+21
-19
lines changed

2 files changed

+21
-19
lines changed

src/containers/app/index.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import React from 'react';
2+
import { withRouter } from 'react-router';
23
import Header from '../../components/header';
34
import Footer from '../../components/footer';
45
import Routes from '../../routes';
@@ -23,7 +24,7 @@ class App extends React.Component {
2324

2425
render() {
2526
const { profile } = this.props;
26-
return(
27+
return (
2728
<div>
2829
<Header profile={profile} />
2930
<Routes />
@@ -48,4 +49,4 @@ const mapDispatchToProps = (dispatch) => bindActionCreators({
4849
getProfile,
4950
}, dispatch);
5051

51-
export default connect(mapStateToProps, mapDispatchToProps)(App);
52+
export default withRouter(connect(mapStateToProps, mapDispatchToProps)(App));

src/routes.js

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import React from 'react';
22
import { Route, Switch } from 'react-router-dom';
3+
import { withRouter } from 'react-router';
34
import Home from './containers/home';
45
import About from './containers/about';
56
import WeAreOpenSource from './containers/about/openSource';
@@ -17,26 +18,26 @@ import EasterEgg from './containers/easter';
1718

1819
class Routes extends React.Component {
1920
render() {
20-
return(
21+
return (
2122
<Switch>
22-
<Route exact path="/" component={ Home } />
23-
<Route path="/about/open-source" component={ WeAreOpenSource } />
24-
<Route path="/about" component={ About } />
25-
<Route path="/signup" component={ Signup } />
26-
<Route path="/learning" component={ LearningPageContainer } />
27-
<Route path="/challenges" component={ ChallengesContainer } />
28-
<Route path="/submit/new/:number" component={ SubmitFormContainer } />
29-
<Route path="/submit/edit/:id" component={ SubmitEditContainer } />
30-
<Route path="/submit/:id" component={ SubmitViewContainer } />
31-
<Route path="/challenge/:number/:title" component={ SingleChallengeContainer } />
32-
<Route path="/profile/edit" component={ ProfileEdit } />
33-
<Route path="/profile/:username?" component={ Profile } />
34-
<Route path="/g/:username" component={ Profile } />
35-
<Route path="/418" component={ () => <EasterEgg type="418" /> } />
36-
<Route component={ e404 } />
23+
<Route exact path="/" component={Home} />
24+
<Route exact path="/about/open-source" component={WeAreOpenSource} />
25+
<Route exact path="/about" component={About} />
26+
<Route exact path="/signup" component={Signup} />
27+
<Route exact path="/learning" component={LearningPageContainer} />
28+
<Route exact path="/challenges" component={ChallengesContainer} />
29+
<Route exact path="/418" component={() => <EasterEgg type="418" />} />
30+
<Route path="/submit/new/:number" component={SubmitFormContainer} />
31+
<Route path="/submit/edit/:id" component={SubmitEditContainer} />
32+
<Route path="/submit/:id" component={SubmitViewContainer} />
33+
<Route path="/challenge/:number/:title" component={SingleChallengeContainer} />
34+
<Route path="/profile/edit" component={ProfileEdit} />
35+
<Route path="/profile/:username?" component={Profile} />
36+
<Route path="/g/:username" component={Profile} />
37+
<Route component={e404} />
3738
</Switch>
3839
);
3940
}
4041
}
4142

42-
export default Routes;
43+
export default withRouter(Routes);

0 commit comments

Comments
 (0)