Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 5 commits
- 29 files changed
- 3 contributors
Commits on Jan 13, 2017
-
Revision of the Exceptions constructors with no params
Motivation ---------- All the java client exceptions having a a method with no parameters dont make a super call. The oracle compiler in compilation time add this call but all the exceptions have as father the CouchbaseException and his no params constructor nor have the super call. This is a problem because the stack trace is never initialized. Modifications ------------- Add super() to all the constructors. Result ------ The Exception is correctly initialized. Change-Id: I24460e247cebc8d7b4275ec55f22cc7591693485 Reviewed-on: http://review.couchbase.org/71182 Reviewed-by: Michael Nitschinger <[email protected]> Tested-by: Michael Nitschinger <[email protected]> Reviewed-on: http://review.couchbase.org/71966 Reviewed-by: Sergey Avseyev <[email protected]>
-
Ignore Guava collection tests by default.
When they are enabled by default and used with the maven command line runner it seems like the test suite never ends. We need to look into this separately but for now we can unblock the testing. Change-Id: I257e3dc6181e0e1f472f91c5b12eaff99c04a79f Reviewed-on: http://review.couchbase.org/71470 Reviewed-by: Sergey Avseyev <[email protected]> Reviewed-by: Subhashni Balakrishnan <[email protected]> Tested-by: Michael Nitschinger <[email protected]> Reviewed-on: http://review.couchbase.org/71969
-
Change-Id: I8513041c6c3bf1a4570c821bfd6c822a3b02fcfa Reviewed-on: http://review.couchbase.org/71968 Tested-by: Michael Nitschinger <[email protected]> Reviewed-by: Sergey Avseyev <[email protected]>
-
JCBC-1035 Fix flaky N1QL cluster level query integration tests
Motivation ---------- N1QL cluster level query tests were quite flaky because the buckets shared the same cluster object which uses one of the open buckets in bucket cache to execute the query. As the bucket cache is a concurrent hash map, there are no order guarantees. Changes ------- Dont share cluster between the buckets. Also used request_plus scan consistency as the read pretty soon after write. Results ------- Tests consistently pass Change-Id: Iaf06b9c82dac8757fceb1575c23e84a583396206 Reviewed-on: http://review.couchbase.org/71562 Tested-by: Subhashni Balakrishnan <[email protected]> Reviewed-by: Michael Nitschinger <[email protected]> Reviewed-on: http://review.couchbase.org/71970 Tested-by: Michael Nitschinger <[email protected]> Reviewed-by: Sergey Avseyev <[email protected]>
-
JCBC-999: Redispatch config messages if failed.
Motivation ---------- If messages going down the config service in core-io, because the sockets are opened dynamically and other components depend on this fail fast mode (while not ideal), such messages need to be retried aggressively to overcome issues where a node is down for example. Modifications ------------- Simple retry logic has been added to the config service messages, retrying after 100ms and as a result providing a better experience, even if a node is down or not reachable. In the future, if needed, we can make this configurable but for now lets just stick with sane defaults. Result ------ Bucket and Cluster-level config messages have a much higher chance of succeeding, even under individual node failures. Change-Id: If27355d444fc411dd933a65e74c07816cb5dd376 Reviewed-on: http://review.couchbase.org/71897 Tested-by: Michael Nitschinger <[email protected]> Reviewed-by: Sergey Avseyev <[email protected]> Reviewed-by: Subhashni Balakrishnan <[email protected]> Reviewed-on: http://review.couchbase.org/71967
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff master...release23