Code Quality: Fixed selecting Omnibar suggestions via keyboard (#17260)

yaira2 · web-flow · commit 3c162d212dc8 · 2025-07-13T23:44:14.000-04:00
diff --git a/src/Files.App.Controls/Omnibar/Omnibar.Events.cs b/src/Files.App.Controls/Omnibar/Omnibar.Events.cs
@@ -131,14 +131,12 @@ private void AutoSuggestBox_TextChanged(object sender, TextChangedEventArgs e)
 
 			// UpdateSuggestionListView();
 
-			if (_textChangeReason is not OmnibarTextChangeReason.SuggestionChosen and
-				not OmnibarTextChangeReason.ProgrammaticChange)
+			if (_textChangeReason is OmnibarTextChangeReason.ProgrammaticChange)
+				_textBox.SelectAll();
+			else
 			{
-				_textChangeReason = OmnibarTextChangeReason.UserInput;
 				_userInput = _textBox.Text;
 			}
-			else if (_textChangeReason is OmnibarTextChangeReason.ProgrammaticChange)
-				_textBox.SelectAll();
 
 			TextChanged?.Invoke(this, new(CurrentSelectedMode, _textChangeReason));
 

Original file line number	Diff line number	Diff line change
`@@ -131,14 +131,12 @@ private void AutoSuggestBox_TextChanged(object sender, TextChangedEventArgs e)`
`131`	`131`
`132`	`132`	`// UpdateSuggestionListView();`
`133`	`133`
`134`		`- if (_textChangeReason is not OmnibarTextChangeReason.SuggestionChosen and`
`135`		`- not OmnibarTextChangeReason.ProgrammaticChange)`
	`134`	`+ if (_textChangeReason is OmnibarTextChangeReason.ProgrammaticChange)`
	`135`	`+ _textBox.SelectAll();`
	`136`	`+ else`
`136`	`137`	`{`
`137`		`- _textChangeReason = OmnibarTextChangeReason.UserInput;`
`138`	`138`	`_userInput = _textBox.Text;`
`139`	`139`	`}`
`140`		`- else if (_textChangeReason is OmnibarTextChangeReason.ProgrammaticChange)`
`141`		`- _textBox.SelectAll();`
`142`	`140`
`143`	`141`	`TextChanged?.Invoke(this, new(CurrentSelectedMode, _textChangeReason));`
`144`	`142`