Declarations4: add RULE-8-2

Author: knewbury01

c/misra/src/rules/RULE-8-2/FunctionTypesNotInPrototypeForm.ql

@@ -0,0 +1,46 @@
+/**
+ * @id c/misra/function-types-not-in-prototype-form
+ * @name RULE-8-2: Function types shall be in prototype form with named parameters
+ * @description Omission of parameter types or names prevents the compiler from doing type checking
+ *              when those functions are used and therefore may result in undefined behaviour.
+ * @kind problem
+ * @precision medium
+ * @problem.severity error
+ * @tags external/misra/id/rule-8-2
+ *       correctness
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.Identifiers
+
+/**
+ * `Parameter`s without names
+ */
+class UnnamedParameter extends Parameter {
+  UnnamedParameter() { not this.isNamed() }
+}
+
+from Function f, string msg
+where
+  not isExcluded(f, Declarations4Package::functionTypesNotInPrototypeFormQuery()) and
+  f instanceof InterestingIdentifiers and
+  (
+    f.getAParameter() instanceof UnnamedParameter and
+    msg = "Function " + f + " declares parameter that is unnamed."
+    or
+    //void keyword not present in function signature, no way to tell which
+    not exists(f.getAParameter()) and
+    msg =
+      "Function " + f +
+        " may not specify all parameter types or may not specifiy void for no parameters present."
+    or
+    exists(Parameter p |
+      p.getFunction() = f and
+      not p.getFile() = f.getFile() and
+      msg = "Function " + f + " declares parameter in unsupported declaration list."
+    )
+  ) and
+  not f.isInMacroExpansion()
+select f, msg

c/misra/test/rules/RULE-8-2/FunctionTypesNotInPrototypeForm.expected

@@ -0,0 +1,5 @@
+| test.c:2:6:2:7 | f0 | Function f0 may not specify all parameter types or may not specifiy void for no parameters present. |
+| test.c:3:6:3:7 | f1 | Function f1 declares parameter that is unnamed. |
+| test.c:4:6:4:7 | f2 | Function f2 may not specify all parameter types or may not specifiy void for no parameters present. |
+| test.c:5:6:5:7 | f3 | Function f3 may not specify all parameter types or may not specifiy void for no parameters present. |
+| test.c:7:5:7:6 | f5 | Function f5 declares parameter in unsupported declaration list. |

c/misra/test/rules/RULE-8-2/FunctionTypesNotInPrototypeForm.qlref

@@ -0,0 +1 @@
+rules/RULE-8-2/FunctionTypesNotInPrototypeForm.ql

c/misra/test/rules/RULE-8-2/test.c

@@ -0,0 +1,9 @@
+void f(int x);    // COMPLIANT
+void f0(void);    // COMPLIANT[FALSE_POSITIVE]
+void f1(int);     // NON_COMPLIANT
+void f2();        // NON_COMPLIANT
+void f3(x);       // NON_COMPLIANT
+void f4(const x); // NON_COMPLIANT[FALSE_NEGATIVE]
+int f5(x)         // NON_COMPLIANT
+int x;
+{ return 1; }

cpp/common/src/codingstandards/cpp/exclusions/c/Declarations4.qll

@@ -3,9 +3,19 @@ import cpp
 import RuleMetadata
 import codingstandards.cpp.exclusions.RuleMetadata
 
-newtype Declarations4Query = TIdentifierWithExternalLinkageOneDefinitionQuery()
+newtype Declarations4Query =
+  TFunctionTypesNotInPrototypeFormQuery() or
+  TIdentifierWithExternalLinkageOneDefinitionQuery()
 
 predicate isDeclarations4QueryMetadata(Query query, string queryId, string ruleId) {
+  query =
+    // `Query` instance for the `functionTypesNotInPrototypeForm` query
+    Declarations4Package::functionTypesNotInPrototypeFormQuery() and
+  queryId =
+    // `@id` for the `functionTypesNotInPrototypeForm` query
+    "c/misra/function-types-not-in-prototype-form" and
+  ruleId = "RULE-8-2"
+  or
   query =
     // `Query` instance for the `identifierWithExternalLinkageOneDefinition` query
     Declarations4Package::identifierWithExternalLinkageOneDefinitionQuery() and
@@ -16,6 +26,13 @@ predicate isDeclarations4QueryMetadata(Query query, string queryId, string ruleI
 }
 
 module Declarations4Package {
+  Query functionTypesNotInPrototypeFormQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `functionTypesNotInPrototypeForm` query
+      TQueryC(TDeclarations4PackageQuery(TFunctionTypesNotInPrototypeFormQuery()))
+  }
+
   Query identifierWithExternalLinkageOneDefinitionQuery() {
     //autogenerate `Query` type
     result =

rule_packages/c/Declarations4.json

@@ -1,5 +1,28 @@
 {
   "MISRA-C-2012": {
+    "RULE-8-2": {
+      "properties": {
+        "obligation": "required"
+      },
+      "queries": [
+        {
+          "description": "Omission of parameter types or names prevents the compiler from doing type checking when those functions are used and therefore may result in undefined behaviour.",
+          "kind": "problem",
+          "name": "Function types shall be in prototype form with named parameters",
+          "precision": "medium",
+          "severity": "error",
+          "short_name": "FunctionTypesNotInPrototypeForm",
+          "tags": [
+            "correctness"
+          ],
+          "implementation_scope": {
+            "description": "This query does not check for implicitly typed parameters and checks function declarations and definitions but not function pointer types. This query cannot determine when the keyword void is used in place of no parameter.",
+            "items": []
+          }
+        }
+      ],
+      "title": "Function types shall be in prototype form with named parameters"
+    },
     "RULE-8-6": {
       "properties": {
         "obligation": "required"

rules.csv

@@ -647,7 +647,7 @@ c,MISRA-C-2012,RULE-7-2,Yes,Required,,,A �u� or �U� suffix shall be appl
 c,MISRA-C-2012,RULE-7-3,Yes,Required,,,The lowercase character �l� shall not be used in a literal suffix,M2-13-4,Syntax,Easy,
 c,MISRA-C-2012,RULE-7-4,Yes,Required,,,A string literal shall not be assigned to an object unless the object�s type is �pointer to const-qualified char�,A2-13-4,Types,Easy,
 c,MISRA-C-2012,RULE-8-1,Yes,Required,,,Types shall be explicitly specified,,Declarations3,Medium,
-c,MISRA-C-2012,RULE-8-2,Yes,Required,,,Function types shall be in prototype form with named parameters,,Declarations,Medium,
+c,MISRA-C-2012,RULE-8-2,Yes,Required,,,Function types shall be in prototype form with named parameters,,Declarations4,Medium,
 c,MISRA-C-2012,RULE-8-3,Yes,Required,,,All declarations of an object or function shall use the same names and type qualifiers,M3-2-1,Declarations,Medium,
 c,MISRA-C-2012,RULE-8-4,Yes,Required,,,A compatible declaration shall be visible when an object or function with external linkage is defined,,Declarations,Medium,
 c,MISRA-C-2012,RULE-8-5,Yes,Required,,,An external object or function shall be declared once in one and only one file,,Declarations,Medium,