Skip to content

Commit 472a6b5

Browse files
authored
Merge pull request #20018 from owen-mc/java/snakeyaml-safe-unsafe-deserialization
Java: Update qhelp: SnakeYaml is safe from version 2.0
2 parents d5cdfc6 + 9ef22ff commit 472a6b5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

java/ql/src/Security/CWE/CWE-502/UnsafeDeserialization.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ Recommendations specific to particular frameworks supported by this query:
6464
<p></p>
6565
<p><b>SnakeYAML</b> - <code>org.yaml:snakeyaml</code></p>
6666
<ul>
67-
<li><b>Secure by Default</b>: No</li>
68-
<li><b>Recommendation</b>: Pass an instance of <code>org.yaml.snakeyaml.constructor.SafeConstructor</code> to <code>org.yaml.snakeyaml.Yaml</code>'s constructor before using it to deserialize untrusted data.</li>
67+
<li><b>Secure by Default</b>: As of version 2.0.</li>
68+
<li><b>Recommendation</b>: For versions before 2.0, pass an instance of <code>org.yaml.snakeyaml.constructor.SafeConstructor</code> to <code>org.yaml.snakeyaml.Yaml</code>'s constructor before using it to deserialize untrusted data.</li>
6969
</ul>
7070
<p></p>
7171
<p><b>XML Decoder</b> - <code>Standard Java Library</code></p>
@@ -121,7 +121,7 @@ Alvaro Muñoz &amp; Christian Schneider, RSAConference 2016:
121121
</li>
122122
<li>
123123
SnakeYaml documentation on deserialization:
124-
<a href="https://bitbucket.org/snakeyaml/snakeyaml/wiki/Documentation#markdown-header-loading-yaml">SnakeYaml deserialization</a>.
124+
<a href="https://bitbucket.org/snakeyaml/snakeyaml/wiki/Documentation#markdown-header-loading-yaml">SnakeYaml deserialization</a> (not updated for new behaviour in version 2.0).
125125
</li>
126126
<li>
127127
Hessian deserialization and related gadget chains:

0 commit comments

Comments
 (0)