Skip to content
This repository was archived by the owner on Dec 22, 2024. It is now read-only.

Commit ec9769c

Browse files
Added/reviewed some notes
1 parent 27c65e7 commit ec9769c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/deviceContext.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,12 +135,12 @@ export class DeviceContext implements IDeviceContext, vscode.Disposable {
135135
*
136136
* TODO EW, 2020-02-18:
137137
* A problem I discovered: here you try to find the config file ___location
138-
* and when you're writing below, you use a hardcoded ___location. When
138+
* and when you're writing below, you use a hard-coded ___location. When
139139
* resorting to "find", you have to store the file's ___location at least and
140140
* reuse it when saving.
141141
* But I think the intention is: load a config file from anywhere and save
142142
* it under .vscode/arduino.json. But then the initial load has to use find
143-
* and afterwards it must not use it anymore.
143+
* and afterwards it must not use find anymore.
144144
*/
145145
public loadContext(): Thenable<object> {
146146
return vscode.workspace.findFiles(ARDUINO_CONFIG_FILE, null, 1)
@@ -295,7 +295,7 @@ export class DeviceContext implements IDeviceContext, vscode.Disposable {
295295
validateInput: (value) => {
296296
/* TODO (EW, 2020-02-18):
297297
* is 'c' actually allowed? Also found on within other files.
298-
* And the regular expression doesn't need the intenal groups.
298+
* And the regular expression doesn't need the internal groups.
299299
* The outer group can be an anonymous group.
300300
* And \w doesn't match dashes - so any sketch containing dashes
301301
* will not be found.

src/extension.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,11 @@ export async function activate(context: vscode.ExtensionContext) {
189189
});
190190

191191
registerArduinoCommand("arduino.selectProgrammer", async () => {
192-
// TODO EW: this guard does not prevent building when setting the programmer
192+
// Note: this guard does not prevent building while setting the
193+
// programmer. But when looking at the code of selectProgrammer
194+
// it seems not to be possible to trigger building while setting
195+
// the programmer. If the timed IntelliSense analysis is triggered
196+
// this is not a problem, since it doesn't use the programmer.
193197
if (!arduinoContextModule.default.arduinoApp.building) {
194198
try {
195199
await arduinoContextModule.default.arduinoApp.programmerManager.selectProgrammer();

0 commit comments

Comments
 (0)