Skip to content

Commit 4a8db23

Browse files
committed
- Not exporting unused exports
1 parent c9b232e commit 4a8db23

File tree

4 files changed

+25
-13
lines changed

4 files changed

+25
-13
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "openapi-typescript-codegen",
3-
"version": "0.4.1",
3+
"version": "0.4.4",
44
"description": "NodeJS library that generates Typescript or Javascript clients based on the OpenAPI specification.",
55
"author": "Ferdi Koomen",
66
"homepage": "https://github.com/ferdikoomen/openapi-typescript-codegen",

src/templates/exportService.hbs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,15 @@
88
import { {{{this}}} } from '../models/{{{this}}}';
99
{{/each}}
1010
{{/if}}
11+
{{#if hasApiErrors}}
1112
import { ApiError, catchGenericError } from '../core/ApiError';
13+
{{else}}
14+
import { catchGenericError } from '../core/ApiError';
15+
{{/if}}
1216
import { request as __request } from '../core/request';
17+
{{#if hasApiVersion}}
1318
import { OpenAPI } from '../core/OpenAPI';
19+
{{/if}}
1420

1521
export class {{{name}}} {
1622

src/utils/writeClientServices.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import { writeFile } from './fileSystem';
55
import { format } from './format';
66
import { Templates } from './registerHandlebarTemplates';
77

8+
const VERSION_TEMPLATE_STRING = 'OpenAPI.VERSION';
9+
810
/**
911
* Generate Services using the Handlebar template and write to disk.
1012
* @param services Array of Services to write.
@@ -15,8 +17,12 @@ import { Templates } from './registerHandlebarTemplates';
1517
export async function writeClientServices(services: Service[], templates: Templates, outputPath: string, useOptions: boolean): Promise<void> {
1618
for (const service of services) {
1719
const file = path.resolve(outputPath, `${service.name}.ts`);
20+
const hasApiErrors = service.operations.some(operation => operation.errors.length);
21+
const hasApiVersion = service.operations.some(operation => operation.path.includes(VERSION_TEMPLATE_STRING));
1822
const templateResult = templates.service({
1923
...service,
24+
hasApiErrors,
25+
hasApiVersion,
2026
useOptions,
2127
});
2228
await writeFile(file, format(templateResult));

test/__snapshots__/index.spec.js.snap

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2024,7 +2024,7 @@ exports[`v2 should generate: ./test/result/v2/services/DefaultsService.ts 1`] =
20242024
import { ModelThatExtends } from '../models/ModelThatExtends';
20252025
import { ModelThatExtendsExtends } from '../models/ModelThatExtendsExtends';
20262026
import { ModelWithString } from '../models/ModelWithString';
2027-
import { ApiError, catchGenericError } from '../core/ApiError';
2027+
import { catchGenericError } from '../core/ApiError';
20282028
import { request as __request } from '../core/request';
20292029
import { OpenAPI } from '../core/OpenAPI';
20302030

@@ -2164,7 +2164,7 @@ exports[`v2 should generate: ./test/result/v2/services/DuplicateService.ts 1`] =
21642164
/* eslint-disable */
21652165
/* prettier-ignore */
21662166

2167-
import { ApiError, catchGenericError } from '../core/ApiError';
2167+
import { catchGenericError } from '../core/ApiError';
21682168
import { request as __request } from '../core/request';
21692169
import { OpenAPI } from '../core/OpenAPI';
21702170

@@ -2278,7 +2278,7 @@ exports[`v2 should generate: ./test/result/v2/services/ParametersService.ts 1`]
22782278
/* eslint-disable */
22792279
/* prettier-ignore */
22802280

2281-
import { ApiError, catchGenericError } from '../core/ApiError';
2281+
import { catchGenericError } from '../core/ApiError';
22822282
import { request as __request } from '../core/request';
22832283
import { OpenAPI } from '../core/OpenAPI';
22842284

@@ -2464,7 +2464,7 @@ exports[`v2 should generate: ./test/result/v2/services/SimpleService.ts 1`] = `
24642464
/* eslint-disable */
24652465
/* prettier-ignore */
24662466

2467-
import { ApiError, catchGenericError } from '../core/ApiError';
2467+
import { catchGenericError } from '../core/ApiError';
24682468
import { request as __request } from '../core/request';
24692469
import { OpenAPI } from '../core/OpenAPI';
24702470

@@ -2585,7 +2585,7 @@ exports[`v2 should generate: ./test/result/v2/services/TypesService.ts 1`] = `
25852585
/* prettier-ignore */
25862586

25872587
import { Dictionary } from '../models/Dictionary';
2588-
import { ApiError, catchGenericError } from '../core/ApiError';
2588+
import { catchGenericError } from '../core/ApiError';
25892589
import { request as __request } from '../core/request';
25902590
import { OpenAPI } from '../core/OpenAPI';
25912591

@@ -4801,7 +4801,7 @@ exports[`v3 should generate: ./test/result/v3/services/DefaultsService.ts 1`] =
48014801
import { ModelThatExtends } from '../models/ModelThatExtends';
48024802
import { ModelThatExtendsExtends } from '../models/ModelThatExtendsExtends';
48034803
import { ModelWithString } from '../models/ModelWithString';
4804-
import { ApiError, catchGenericError } from '../core/ApiError';
4804+
import { catchGenericError } from '../core/ApiError';
48054805
import { request as __request } from '../core/request';
48064806
import { OpenAPI } from '../core/OpenAPI';
48074807

@@ -4941,7 +4941,7 @@ exports[`v3 should generate: ./test/result/v3/services/DuplicateService.ts 1`] =
49414941
/* eslint-disable */
49424942
/* prettier-ignore */
49434943

4944-
import { ApiError, catchGenericError } from '../core/ApiError';
4944+
import { catchGenericError } from '../core/ApiError';
49454945
import { request as __request } from '../core/request';
49464946
import { OpenAPI } from '../core/OpenAPI';
49474947

@@ -5055,7 +5055,7 @@ exports[`v3 should generate: ./test/result/v3/services/MultipartService.ts 1`] =
50555055
/* eslint-disable */
50565056
/* prettier-ignore */
50575057

5058-
import { ApiError, catchGenericError } from '../core/ApiError';
5058+
import { catchGenericError } from '../core/ApiError';
50595059
import { request as __request } from '../core/request';
50605060
import { OpenAPI } from '../core/OpenAPI';
50615061

@@ -5095,7 +5095,7 @@ exports[`v3 should generate: ./test/result/v3/services/ParametersService.ts 1`]
50955095
import { ModelThatExtends } from '../models/ModelThatExtends';
50965096
import { ModelThatExtendsExtends } from '../models/ModelThatExtendsExtends';
50975097
import { ModelWithString } from '../models/ModelWithString';
5098-
import { ApiError, catchGenericError } from '../core/ApiError';
5098+
import { catchGenericError } from '../core/ApiError';
50995099
import { request as __request } from '../core/request';
51005100
import { OpenAPI } from '../core/OpenAPI';
51015101

@@ -5347,7 +5347,7 @@ exports[`v3 should generate: ./test/result/v3/services/SimpleService.ts 1`] = `
53475347
/* eslint-disable */
53485348
/* prettier-ignore */
53495349

5350-
import { ApiError, catchGenericError } from '../core/ApiError';
5350+
import { catchGenericError } from '../core/ApiError';
53515351
import { request as __request } from '../core/request';
53525352
import { OpenAPI } from '../core/OpenAPI';
53535353

@@ -5467,7 +5467,7 @@ exports[`v3 should generate: ./test/result/v3/services/TypesService.ts 1`] = `
54675467
/* eslint-disable */
54685468
/* prettier-ignore */
54695469

5470-
import { ApiError, catchGenericError } from '../core/ApiError';
5470+
import { catchGenericError } from '../core/ApiError';
54715471
import { request as __request } from '../core/request';
54725472
import { OpenAPI } from '../core/OpenAPI';
54735473

@@ -5536,7 +5536,7 @@ exports[`v3 should generate: ./test/result/v3/services/UploadService.ts 1`] = `
55365536
/* eslint-disable */
55375537
/* prettier-ignore */
55385538

5539-
import { ApiError, catchGenericError } from '../core/ApiError';
5539+
import { catchGenericError } from '../core/ApiError';
55405540
import { request as __request } from '../core/request';
55415541
import { OpenAPI } from '../core/OpenAPI';
55425542

0 commit comments

Comments
 (0)