From 6ca91fa8e32db075c65a1c2bd8a45c92c7cd7cca Mon Sep 17 00:00:00 2001 From: Ben Hutton Date: Thu, 19 Nov 2020 17:20:29 +0000 Subject: [PATCH 1/3] Attempt to justify and explain unevaluated keyword phrasing Fixes #998 --- jsonschema-core.xml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/jsonschema-core.xml b/jsonschema-core.xml index 95fe91c4..0f8bb73f 100644 --- a/jsonschema-core.xml +++ b/jsonschema-core.xml @@ -2576,6 +2576,14 @@ to contribute to whether or not the item or property has been evaluated. Only successful evaluations are considered. + + If an item in an array or an object property is "successfully evaluated", it + is logically considered to be valid in terms of the representation of the + object or array that's expected. For example if a subschema represents a car, + which requires between 2-4 wheeles, and the value of "wheeles" is 6, the instance + object is not "evaluated" to be a car, and the "wheeles" property is considerd + "unevaluated (successfully as a known thing)", and does not retain any annotations. + Recall that adjacent keywords are keywords within the same schema object, and that the dynamic-scope subschemas include reference targets as well as From d5b7385b57be91c7a4459ad6ee36c50b6fed4bdf Mon Sep 17 00:00:00 2001 From: Ben Hutton Date: Sun, 22 Nov 2020 06:54:11 +0000 Subject: [PATCH 2/3] Update jsonschema-core.xml Co-authored-by: Karen Etheridge --- jsonschema-core.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jsonschema-core.xml b/jsonschema-core.xml index 0f8bb73f..d4429969 100644 --- a/jsonschema-core.xml +++ b/jsonschema-core.xml @@ -2581,7 +2581,7 @@ is logically considered to be valid in terms of the representation of the object or array that's expected. For example if a subschema represents a car, which requires between 2-4 wheeles, and the value of "wheeles" is 6, the instance - object is not "evaluated" to be a car, and the "wheeles" property is considerd + object is not "evaluated" to be a car, and the "wheeles" property is considered "unevaluated (successfully as a known thing)", and does not retain any annotations. From 4c4efc6fe95431baddbafcf025db862a3d1100a6 Mon Sep 17 00:00:00 2001 From: Ben Hutton Date: Sun, 22 Nov 2020 21:46:46 +0000 Subject: [PATCH 3/3] /wheeles/wheels/ --- jsonschema-core.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/jsonschema-core.xml b/jsonschema-core.xml index d4429969..3467c6c3 100644 --- a/jsonschema-core.xml +++ b/jsonschema-core.xml @@ -2580,8 +2580,8 @@ If an item in an array or an object property is "successfully evaluated", it is logically considered to be valid in terms of the representation of the object or array that's expected. For example if a subschema represents a car, - which requires between 2-4 wheeles, and the value of "wheeles" is 6, the instance - object is not "evaluated" to be a car, and the "wheeles" property is considered + which requires between 2-4 wheels, and the value of "wheels" is 6, the instance + object is not "evaluated" to be a car, and the "wheels" property is considered "unevaluated (successfully as a known thing)", and does not retain any annotations.