Adds additional swiftlint rules

Author: kelvinlauKL

SwiftAlgorithmClub/.swiftlint.yml

@@ -0,0 +1,92 @@
+opt_in_rules:
+  - array_init
+    - closure_spacing
+    - contains_over_filter_count
+    - contains_over_filter_is_empty
+    - contains_over_first_not_nil
+    - discouraged_object_literal
+    - empty_collection_literal
+    - empty_count
+    - empty_string
+    - explicit_init
+    - file_header
+    - first_where
+    - identical_operands
+    - implicit_return
+    - implicitly_unwrapped_optional
+    - joined_default_parameter
+    - last_where
+    - legacy_multiple
+    - legacy_random
+    - lower_acl_than_parent
+    - modifier_order
+    - multiline_parameters
+    - nimble_operator
+    - nslocalizedstring_key
+    - operator_usage_whitespace
+    - overridden_super_call
+    - override_in_extension
+    - pattern_matching_keywords
+    - private_action
+    - private_over_fileprivate
+    - prohibited_interface_builder
+    - prohibited_super_call
+    - quick_discouraged_call
+    - quick_discouraged_focused_test
+    - quick_discouraged_pending_test
+    - redundant_nil_coalescing
+    - single_test_class
+    - sorted_first_last
+    - sorted_imports
+    - toggle_bool
+    - trailing_closure
+    - unneeded_parentheses_in_closure_argument
+    - unowned_variable_capture
+    - untyped_error_in_catch
+    - vertical_parameter_alignment_on_call
+    - vertical_whitespace_opening_braces
+    - vertical_whitespace_closing_braces
+    - yoda_condition
+
+disabled_rules:
+  - identifier_name
+  - type_name
+  - line_length
+  - force_try
+  - force_cast
+
+file_length: 450
+nesting:
+  type_level: 3
+swiftlint_version: 0.36.0
+
+cyclomatic_complexity:
+  ignores_case_statements: true
+
+explicit_type_interface:
+  excluded:
+    - local
+
+identifier_name:
+  excluded:
+    - id
+
+discouraged_object_literal:
+  color_literal: false
+
+trailing_closure:
+  only_single_muted_parameter: true
+
+modifier_order:
+  preferred_modifier_order:
+    - acl
+      - setter ACL
+        - override
+        - dynamic
+        - mutators
+        - lazy
+        - final
+        - required
+        - convenience
+        - typeMethods
+        - owned

SwiftAlgorithmClub/AllPairsShortestPaths.playground/Sources/APSP.swift

@@ -13,7 +13,6 @@ import Foundation
  returns an object conforming to `APSPResult`.
  */
 public protocol APSPAlgorithm {
-
   associatedtype Q: Hashable
   associatedtype P: APSPResult
 

SwiftAlgorithmClub/AllPairsShortestPaths.playground/Sources/AdjacencyListGraph.swift

@@ -43,7 +43,7 @@ open class AdjacencyListGraph<T>: AbstractGraph<T> where T: Hashable {
     if let match = vertices.first(where: { $0.data == data }) {
       return match
     }
-    
+
     // if the vertex doesn't exist, create a new one
     let vertex = Vertex(data: data, index: adjacencyList.count)
     adjacencyList.append(EdgeList(vertex: vertex))
@@ -71,13 +71,7 @@ open class AdjacencyListGraph<T>: AbstractGraph<T> where T: Hashable {
       return nil
     }
 
-    for edge: Edge<T> in edges {
-      if edge.to == destinationVertex {
-        return edge.weight
-      }
-    }
-
-    return nil
+    return edges.first { $0.to == destinationVertex }?.weight
   }
 
   open override func edgesFrom(_ sourceVertex: Vertex<T>) -> [Edge<T>] {

SwiftAlgorithmClub/AllPairsShortestPaths.playground/Sources/FloydWarshall.swift

@@ -59,11 +59,11 @@ public struct FloydWarshall<T>: APSPAlgorithm where T: Hashable {
    shortest paths and the corresponding predecessor matrix
    */
   static fileprivate func nextStep<T>(_ intermediateIdx: Int, previousDistances: Distances,
-                               previousPredecessors: Predecessors, graph: AbstractGraph<T>) -> StepResult {
+                                      previousPredecessors: Predecessors, graph: AbstractGraph<T>) -> StepResult {
 
     let vertexCount = graph.vertices.count
     var nextDistances = Array(repeating: Array(repeating: Double.infinity, count: vertexCount), count: vertexCount)
-    var nextPredecessors = Array(repeating: Array<Int?>(repeating: nil, count: vertexCount), count: vertexCount)
+    var nextPredecessors = Array(repeating: [Int?](repeating: nil, count: vertexCount), count: vertexCount)
 
     for fromIdx in 0 ..< vertexCount {
       for toIndex in 0 ..< vertexCount {
@@ -127,7 +127,7 @@ public struct FloydWarshall<T>: APSPAlgorithm where T: Hashable {
   static fileprivate func constructInitialPredecessorMatrix(_ distances: Distances) -> Predecessors {
 
     let vertexCount = distances.count
-    var predecessors = Array(repeating: Array<Int?>(repeating: nil, count: vertexCount), count: vertexCount)
+    var predecessors = Array(repeating: [Int?](repeating: nil, count: vertexCount), count: vertexCount)
 
     for fromIdx in 0 ..< vertexCount {
       for toIdx in 0 ..< vertexCount {
@@ -190,7 +190,7 @@ public struct FloydWarshallResult<T>: APSPResult where T: Hashable {
    - returns: the list of predecessors discovered so far
    */
   fileprivate func recursePathFrom(fromVertex from: Vertex<T>, toVertex to: Vertex<T>, path: [Vertex<T>],
-                                          inGraph graph: AbstractGraph<T>) -> [Vertex<T>]? {
+                                   inGraph graph: AbstractGraph<T>) -> [Vertex<T>]? {
 
     if from.index == to.index {
       return [ from, to ]

SwiftAlgorithmClub/AllPairsShortestPaths.playground/Sources/Graph.swift

@@ -7,8 +7,7 @@
 
 import Foundation
 
-open class AbstractGraph<T>: CustomStringConvertible where T: Hashable {
-
+open class AbstractGraph<T: Hashable>: CustomStringConvertible {
   public required init() {}
 
   public required init(fromGraph graph: AbstractGraph<T>) {

SwiftAlgorithmClub/Podfile

@@ -0,0 +1,5 @@
+target 'SwiftAlgorithmClub' do
+  use_frameworks!
+
+  pod 'SwiftLint'
+end

SwiftAlgorithmClub/SwiftAlgorithmClub.xcodeproj/project.pbxproj

@@ -8,9 +8,13 @@
 
 /* Begin PBXBuildFile section */
 		60908F9123691B81004E53B2 /* SwiftAlgorithmClub.h in Headers */ = {isa = PBXBuildFile; fileRef = 60908F8F23691B81004E53B2 /* SwiftAlgorithmClub.h */; settings = {ATTRIBUTES = (Public, ); }; };
+		896EC48BF398EBA0498F3F37 /* Pods_SwiftAlgorithmClub.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 4E71A86B58EDBA0CFCF6ACDC /* Pods_SwiftAlgorithmClub.framework */; };
 /* End PBXBuildFile section */
 
 /* Begin PBXFileReference section */
+		19B6A76A8179150D7F857F86 /* Pods-SwiftAlgorithmClub.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SwiftAlgorithmClub.release.xcconfig"; path = "Target Support Files/Pods-SwiftAlgorithmClub/Pods-SwiftAlgorithmClub.release.xcconfig"; sourceTree = "<group>"; };
+		1AC49BC223347449D9B873B3 /* Pods-SwiftAlgorithmClub.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-SwiftAlgorithmClub.debug.xcconfig"; path = "Target Support Files/Pods-SwiftAlgorithmClub/Pods-SwiftAlgorithmClub.debug.xcconfig"; sourceTree = "<group>"; };
+		4E71A86B58EDBA0CFCF6ACDC /* Pods_SwiftAlgorithmClub.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_SwiftAlgorithmClub.framework; sourceTree = BUILT_PRODUCTS_DIR; };
 		60908F8C23691B81004E53B2 /* SwiftAlgorithmClub.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = SwiftAlgorithmClub.framework; sourceTree = BUILT_PRODUCTS_DIR; };
 		60908F8F23691B81004E53B2 /* SwiftAlgorithmClub.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SwiftAlgorithmClub.h; sourceTree = "<group>"; };
 		60908F9023691B81004E53B2 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
@@ -21,6 +25,7 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				896EC48BF398EBA0498F3F37 /* Pods_SwiftAlgorithmClub.framework in Frameworks */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -32,6 +37,8 @@
 			children = (
 				60908F8E23691B81004E53B2 /* SwiftAlgorithmClub */,
 				60908F8D23691B81004E53B2 /* Products */,
+				BA921E75CF90836A6FFD54BD /* Pods */,
+				76C74A433C3D40B49A759205 /* Frameworks */,
 			);
 			sourceTree = "<group>";
 		};
@@ -52,6 +59,23 @@
 			path = SwiftAlgorithmClub;
 			sourceTree = "<group>";
 		};
+		76C74A433C3D40B49A759205 /* Frameworks */ = {
+			isa = PBXGroup;
+			children = (
+				4E71A86B58EDBA0CFCF6ACDC /* Pods_SwiftAlgorithmClub.framework */,
+			);
+			name = Frameworks;
+			sourceTree = "<group>";
+		};
+		BA921E75CF90836A6FFD54BD /* Pods */ = {
+			isa = PBXGroup;
+			children = (
+				1AC49BC223347449D9B873B3 /* Pods-SwiftAlgorithmClub.debug.xcconfig */,
+				19B6A76A8179150D7F857F86 /* Pods-SwiftAlgorithmClub.release.xcconfig */,
+			);
+			path = Pods;
+			sourceTree = "<group>";
+		};
 /* End PBXGroup section */
 
 /* Begin PBXHeadersBuildPhase section */
@@ -70,10 +94,12 @@
 			isa = PBXNativeTarget;
 			buildConfigurationList = 60908F9423691B81004E53B2 /* Build configuration list for PBXNativeTarget "SwiftAlgorithmClub" */;
 			buildPhases = (
+				5B0CDFC13A7E532D8AD759CD /* [CP] Check Pods Manifest.lock */,
 				60908F8723691B81004E53B2 /* Headers */,
 				60908F8823691B81004E53B2 /* Sources */,
 				60908F8923691B81004E53B2 /* Frameworks */,
 				60908F8A23691B81004E53B2 /* Resources */,
+				60B8E3912369304400940496 /* ShellScript */,
 			);
 			buildRules = (
 			);
@@ -126,6 +152,48 @@
 		};
 /* End PBXResourcesBuildPhase section */
 
+/* Begin PBXShellScriptBuildPhase section */
+		5B0CDFC13A7E532D8AD759CD /* [CP] Check Pods Manifest.lock */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputFileListPaths = (
+			);
+			inputPaths = (
+				"${PODS_PODFILE_DIR_PATH}/Podfile.lock",
+				"${PODS_ROOT}/Manifest.lock",
+			);
+			name = "[CP] Check Pods Manifest.lock";
+			outputFileListPaths = (
+			);
+			outputPaths = (
+				"$(DERIVED_FILE_DIR)/Pods-SwiftAlgorithmClub-checkManifestLockResult.txt",
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "diff \"${PODS_PODFILE_DIR_PATH}/Podfile.lock\" \"${PODS_ROOT}/Manifest.lock\" > /dev/null\nif [ $? != 0 ] ; then\n    # print error to STDERR\n    echo \"error: The sandbox is not in sync with the Podfile.lock. Run 'pod install' or update your CocoaPods installation.\" >&2\n    exit 1\nfi\n# This output is used by Xcode 'outputs' to avoid re-running this script phase.\necho \"SUCCESS\" > \"${SCRIPT_OUTPUT_FILE_0}\"\n";
+			showEnvVarsInLog = 0;
+		};
+		60B8E3912369304400940496 /* ShellScript */ = {
+			isa = PBXShellScriptBuildPhase;
+			buildActionMask = 2147483647;
+			files = (
+			);
+			inputFileListPaths = (
+			);
+			inputPaths = (
+			);
+			outputFileListPaths = (
+			);
+			outputPaths = (
+			);
+			runOnlyForDeploymentPostprocessing = 0;
+			shellPath = /bin/sh;
+			shellScript = "# Type a script or drag a script file from your workspace to insert its path.\n\"${PODS_ROOT}/SwiftLint/swiftlint\"\n";
+		};
+/* End PBXShellScriptBuildPhase section */
+
 /* Begin PBXSourcesBuildPhase section */
 		60908F8823691B81004E53B2 /* Sources */ = {
 			isa = PBXSourcesBuildPhase;
@@ -258,6 +326,7 @@
 		};
 		60908F9523691B81004E53B2 /* Debug */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = 1AC49BC223347449D9B873B3 /* Pods-SwiftAlgorithmClub.debug.xcconfig */;
 			buildSettings = {
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;
@@ -282,6 +351,7 @@
 		};
 		60908F9623691B81004E53B2 /* Release */ = {
 			isa = XCBuildConfiguration;
+			baseConfigurationReference = 19B6A76A8179150D7F857F86 /* Pods-SwiftAlgorithmClub.release.xcconfig */;
 			buildSettings = {
 				CODE_SIGN_STYLE = Automatic;
 				COMBINE_HIDPI_IMAGES = YES;