Add controller service capabilities

Signed-off-by: Mayank Shah <[email protected]>

Author: mayankshah1607

pkg/nfs/controllerserver.go

@@ -220,8 +220,8 @@ func (cs *ControllerServer) internalMount(ctx context.Context, vol *nfsVolume) e
 	_, err := cs.Driver.ns.NodePublishVolume(ctx, &csi.NodePublishVolumeRequest{
 		TargetPath: targetPath,
 		VolumeContext: map[string]string{
-			"server": vol.server,
-			"share":  sharePath,
+			paramServer: vol.server,
+			attrShare:   sharePath,
 		},
 		VolumeCapability: &stdVolCap,
 		VolumeId:         vol.id,
@@ -281,6 +281,10 @@ func (cs *ControllerServer) newNFSVolume(name string, params map[string]string)
 
 // Get working directory for CreateVolume and DeleteVolume
 func (cs *ControllerServer) getInternalMountPath(vol *nfsVolume) string {
+	// use default if empty
+	if cs.workingMountDir == "" {
+		cs.workingMountDir = "/mnt"
+	}
 	return filepath.Join(cs.workingMountDir, vol.subDir)
 }
 
@@ -312,21 +316,6 @@ func (cs *ControllerServer) nfsVolToCSI(vol *nfsVolume, reqBytes int64) *csi.Vol
 	}
 }
 
-// Given a CSI volume id, return a nfsVolume
-func (cs *ControllerServer) getNfsVolFromId(id string) (*nfsVolume, error) {
-	tokens := strings.Split(id, "/")
-	if len(tokens) != totalIDElements {
-		return nil, fmt.Errorf("volume id %q unexpected format: got %v tokens", id, len(tokens))
-	}
-
-	return &nfsVolume{
-		id:      id,
-		server:  tokens[idServer],
-		baseDir: tokens[idBaseDir],
-		subDir:  tokens[idSubDir],
-	}, nil
-}
-
 // Given a nfsVolume, return a CSI volume id
 func (cs *ControllerServer) getVolumeIdFromNfsVol(vol *nfsVolume) string {
 	idElements := make([]string, totalIDElements)

pkg/nfs/nfs.go

@@ -69,7 +69,9 @@ func NewNFSdriver(nodeID, endpoint string, perm *uint32) *nfsDriver {
 	// NFS plugin does not support ControllerServiceCapability now.
 	// If support is added, it should set to appropriate
 	// ControllerServiceCapability RPC types.
-	n.AddControllerServiceCapabilities([]csi.ControllerServiceCapability_RPC_Type{csi.ControllerServiceCapability_RPC_UNKNOWN})
+	n.AddControllerServiceCapabilities([]csi.ControllerServiceCapability_RPC_Type{
+		csi.ControllerServiceCapability_RPC_CREATE_DELETE_VOLUME,
+	})
 	return n
 }