Eliminate in_array() function calls.

sebastianbergmann · sebastianbergmann · commit 1ebad53b7ec6 · 2009-12-11T17:57:19.000-06:00
diff --git a/PHP/CodeCoverage.php b/PHP/CodeCoverage.php
@@ -458,6 +458,7 @@ protected function getLinesByStatus(array $data, $status)
 
         $isFileCache = array();
         $result      = array();
+        $status      = array_flip($status);
 
         foreach ($data as $file => $coverage) {
             if (!isset($isFileCache[$file])) {
@@ -471,7 +472,7 @@ protected function getLinesByStatus(array $data, $status)
             $result[$file] = array();
 
             foreach ($coverage as $line => $_status) {
-                if (in_array($_status, $status)) {
+                if (isset($status[$_status])) {
                     $result[$file][$line] = $_status;
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -458,6 +458,7 @@ protected function getLinesByStatus(array $data, $status)`
`458`	`458`
`459`	`459`	`$isFileCache = array();`
`460`	`460`	`$result = array();`
	`461`	`+ $status = array_flip($status);`
`461`	`462`
`462`	`463`	`foreach ($data as $file => $coverage) {`
`463`	`464`	`if (!isset($isFileCache[$file])) {`
`@@ -471,7 +472,7 @@ protected function getLinesByStatus(array $data, $status)`
`471`	`472`	`$result[$file] = array();`
`472`	`473`
`473`	`474`	`foreach ($coverage as $line => $_status) {`
`474`		`- if (in_array($_status, $status)) {`
	`475`	`+ if (isset($status[$_status])) {`
`475`	`476`	`$result[$file][$line] = $_status;`
`476`	`477`	`}`
`477`	`478`	`}`