Eliminate superfluous function calls.

sebastianbergmann · sebastianbergmann · commit 9c21a9a33581 · 2009-11-14T10:50:54.000+01:00
diff --git a/PHP/CodeCoverage.php b/PHP/CodeCoverage.php
@@ -184,7 +184,7 @@ public function append(array $data, $id = NULL)
         unset($newFiles);
 
         // Apply @covers filtering.
-        if (is_object($id) && $id instanceof PHPUnit_Framework_TestCase) {
+        if ($id instanceof PHPUnit_Framework_TestCase) {
             $linesToBeCovered = PHP_CodeCoverage_Util::getLinesToBeCovered(
               get_class($id), $id->getName()
             );
@@ -214,7 +214,7 @@ public function append(array $data, $id = NULL)
         }
 
         if (!empty($data)) {
-            if (is_object($id) && $id instanceof PHPUnit_Framework_TestCase) {
+            if ($id instanceof PHPUnit_Framework_TestCase) {
                 $id = get_class($id) . '::' . $id->getName();
             }
 

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ public function append(array $data, $id = NULL)`
`184`	`184`	`unset($newFiles);`
`185`	`185`
`186`	`186`	`// Apply @covers filtering.`
`187`		`- if (is_object($id) && $id instanceof PHPUnit_Framework_TestCase) {`
	`187`	`+ if ($id instanceof PHPUnit_Framework_TestCase) {`
`188`	`188`	`$linesToBeCovered = PHP_CodeCoverage_Util::getLinesToBeCovered(`
`189`	`189`	`get_class($id), $id->getName()`
`190`	`190`	`);`
`@@ -214,7 +214,7 @@ public function append(array $data, $id = NULL)`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`if (!empty($data)) {`
`217`		`- if (is_object($id) && $id instanceof PHPUnit_Framework_TestCase) {`
	`217`	`+ if ($id instanceof PHPUnit_Framework_TestCase) {`
`218`	`218`	`$id = get_class($id) . '::' . $id->getName();`
`219`	`219`	`}`
`220`	`220`