Refactor.

Author: sebastianbergmann

PHP/CodeCoverage.php

@@ -178,6 +178,18 @@ public function append(array $data, $id = NULL)
             throw new InvalidArgumentException;
         }
 
+        $dir = dirname(__FILE__);
+
+        foreach (array_keys($data) as $file) {
+            if (strpos($file, $dir) === 0 ||
+                substr($file, -17) == 'File/Iterator.php' ||
+                substr($file, -25) == 'File/Iterator/Factory.php') {
+                unset($data[$file]);
+            }
+        }
+
+        unset($dir, $file);
+
         // Process files that are covered for the first time.
         $newFiles = array_diff_key($data, $this->coveredFiles);
 

PHP/CodeCoverage/Driver.php

@@ -44,7 +44,7 @@
  */
 
 /**
- * Abstract base class for code coverage drivers.
+ * Interface for code coverage drivers.
  *
  * @category   PHP
  * @package    CodeCoverage
@@ -55,34 +55,18 @@
  * @link       http://github.com/sebastianbergmann/php-code-coverage
  * @since      Class available since Release 1.0.0
  */
-abstract class PHP_CodeCoverage_Driver
+interface PHP_CodeCoverage_Driver
 {
-    /**
-     * @param array $codeCoverage
-     */
-    protected function filter(&$codeCoverage)
-    {
-        $dir = dirname(dirname(__FILE__));
-
-        foreach (array_keys($codeCoverage) as $file) {
-            if (strpos($file, $dir) === 0 ||
-                substr($file, -17) == 'File/Iterator.php' ||
-                substr($file, -25) == 'File/Iterator/Factory.php') {
-                unset($codeCoverage[$file]);
-            }
-        }
-    }
-
     /**
      * Start collection of code coverage information.
      */
-    abstract public function start();
+    public function start();
 
     /**
      * Stop collection of code coverage information.
      *
      * @return array
      */
-    abstract public function stop();
+    public function stop();
 }
 ?>

PHP/CodeCoverage/Driver/Xdebug.php

@@ -57,7 +57,7 @@
  * @link       http://github.com/sebastianbergmann/php-code-coverage
  * @since      Class available since Release 1.0.0
  */
-class PHP_CodeCoverage_Driver_Xdebug extends PHP_CodeCoverage_Driver
+class PHP_CodeCoverage_Driver_Xdebug implements PHP_CodeCoverage_Driver
 {
     /**
      * Start collection of code coverage information.
@@ -77,8 +77,6 @@ public function stop()
         $codeCoverage = xdebug_get_code_coverage();
         xdebug_stop_code_coverage();
 
-        $this->filter($codeCoverage);
-
         return $codeCoverage;
     }
 }