[win][arm64ec] More fixes for building and testing Arm64EC Windows

Author: dpaoliello

llvm/.gitattributes

@@ -32,3 +32,4 @@ test/tools/split-file/basic.test text eol=lf
 test/tools/split-file/Inputs/basic-*.txt eol=lf
 test/tools/split-file/basic.crlf.test text eol=crlf
 test/tools/split-file/Inputs/basic-*.crlf eol=crlf
+test/tools/llvm-objcopy/MachO/Inputs/macho_sections.s text eol=lf

llvm/lib/IR/Mangler.cpp

@@ -292,6 +292,9 @@ void llvm::emitLinkerFlagsForUsedCOFF(raw_ostream &OS, const GlobalValue *GV,
 }
 
 std::optional<std::string> llvm::getArm64ECMangledFunctionName(StringRef Name) {
+  if (Name.empty())
+    reportFatalUsageError("ARM64EC does not support empty function names");
+
   if (Name[0] != '?') {
     // For non-C++ symbols, prefix the name with "#" unless it's already
     // mangled.

llvm/lib/Target/AArch64/AArch64Arm64ECCallLowering.cpp

@@ -727,9 +727,6 @@ AArch64Arm64ECCallLowering::buildPatchableThunk(GlobalAlias *UnmangledAlias,
 
 // Lower an indirect call with inline code.
 void AArch64Arm64ECCallLowering::lowerCall(CallBase *CB) {
-  assert(CB->getModule()->getTargetTriple().isOSWindows() &&
-         "Only applicable for Windows targets");
-
   IRBuilder<> B(CB);
   Value *CalledOperand = CB->getCalledOperand();
 
@@ -872,7 +869,7 @@ bool AArch64Arm64ECCallLowering::runOnModule(Module &Mod) {
     if (!F.isDeclaration() && (!F.hasLocalLinkage() || F.hasAddressTaken()) &&
         F.getCallingConv() != CallingConv::ARM64EC_Thunk_Native &&
         F.getCallingConv() != CallingConv::ARM64EC_Thunk_X64) {
-      if (!F.hasComdat())
+      if (!F.hasComdat() && !F.isDeclarationForLinker())
         F.setComdat(Mod.getOrInsertComdat(F.getName()));
       ThunkMapping.push_back(
           {&F, buildEntryThunk(&F), Arm64ECThunkType::Entry});

llvm/test/CodeGen/Generic/allow-check.ll

@@ -6,6 +6,7 @@
 ; XFAIL: target=nvptx{{.*}}
 ; XFAIL: target=sparc{{.*}}
 ; XFAIL: target=hexagon-{{.*}}
+; XFAIL: target=arm64ec-{{.*}}
 
 ; RUN: llc < %s -O3 -global-isel=0 -fast-isel=0
 ; RUN: llc < %s -O3 -global-isel=1 -fast-isel=0

llvm/test/CodeGen/Generic/vector-constantexpr.ll

@@ -1,6 +1,6 @@
 ; RUN: llc < %s
 
-define void @""(ptr %inregs, ptr %outregs) {
+define void @test(ptr %inregs, ptr %outregs) {
         %a_addr.i = alloca <4 x float>          ; <ptr> [#uses=1]
         store <4 x float> < float undef, float undef, float undef, float undef >, ptr %a_addr.i
         ret void