Skip to content

Commit 9c457fd

Browse files
committed
fixup! [AMDGPU] Ensure non-reserved CSR spilled regs are live-in
1 parent 0050630 commit 9c457fd

File tree

2 files changed

+97
-125
lines changed

2 files changed

+97
-125
lines changed

llvm/test/CodeGen/AMDGPU/bug-undef-spilled-agpr.ll

Lines changed: 0 additions & 125 deletions
This file was deleted.
Lines changed: 97 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,97 @@
1+
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
2+
# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx908 -run-pass=si-lower-sgpr-spills,greedy,si-lower-wwm-copies,virtregrewriter,prologepilog -verify-machineinstrs -o - %s | FileCheck -check-prefix=GCN %s
3+
4+
---
5+
name: widget
6+
tracksRegLiveness: true
7+
frameInfo:
8+
adjustsStack: true
9+
stack:
10+
- { id: 0, type: spill-slot, size: 4, alignment: 4, stack-id: sgpr-spill }
11+
- { id: 1, type: spill-slot, size: 4, alignment: 4, stack-id: sgpr-spill }
12+
machineFunctionInfo:
13+
hasSpilledSGPRs: true
14+
scratchRSrcReg: '$sgpr0_sgpr1_sgpr2_sgpr3'
15+
stackPtrOffsetReg: '$sgpr32'
16+
body: |
17+
; GCN-LABEL: name: widget
18+
; GCN: bb.0:
19+
; GCN-NEXT: successors: %bb.1(0x80000000)
20+
; GCN-NEXT: liveins: $sgpr12, $sgpr13, $sgpr14, $sgpr15, $agpr0
21+
; GCN-NEXT: {{ $}}
22+
; GCN-NEXT: $sgpr4_sgpr5 = S_XOR_SAVEEXEC_B64 -1, implicit-def $exec, implicit-def dead $scc, implicit $exec
23+
; GCN-NEXT: $vgpr63 = V_ACCVGPR_READ_B32_e64 $agpr0, implicit $exec
24+
; GCN-NEXT: BUFFER_STORE_DWORD_OFFSET $vgpr63, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, implicit $exec :: (store (s32) into %stack.2, addrspace 5)
25+
; GCN-NEXT: $exec = S_MOV_B64 -1
26+
; GCN-NEXT: BUFFER_STORE_DWORD_OFFSET killed $vgpr62, $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, implicit $exec :: (store (s32) into %stack.3, addrspace 5)
27+
; GCN-NEXT: $exec = S_MOV_B64 killed $sgpr4_sgpr5
28+
; GCN-NEXT: renamable $vgpr62 = IMPLICIT_DEF
29+
; GCN-NEXT: $vgpr62 = SI_SPILL_S32_TO_VGPR $sgpr15, 0, killed $vgpr62
30+
; GCN-NEXT: $noreg = S_OR_SAVEEXEC_B64 -1, implicit-def $exec, implicit-def dead $scc, implicit $exec
31+
; GCN-NEXT: renamable $agpr0 = COPY killed renamable $vgpr62
32+
; GCN-NEXT: $exec = S_MOV_B64 killed $noreg
33+
; GCN-NEXT: renamable $vgpr62 = IMPLICIT_DEF
34+
; GCN-NEXT: dead renamable $vgpr62 = V_AND_B32_e32 1, killed $vgpr62, implicit $exec
35+
; GCN-NEXT: {{ $}}
36+
; GCN-NEXT: bb.1:
37+
; GCN-NEXT: successors: %bb.3(0x40000000), %bb.2(0x40000000)
38+
; GCN-NEXT: liveins: $agpr0
39+
; GCN-NEXT: {{ $}}
40+
; GCN-NEXT: S_CBRANCH_EXECZ %bb.2, implicit $exec
41+
; GCN-NEXT: S_BRANCH %bb.3
42+
; GCN-NEXT: {{ $}}
43+
; GCN-NEXT: bb.2:
44+
; GCN-NEXT: successors: %bb.4(0x04000000), %bb.1(0x7c000000)
45+
; GCN-NEXT: liveins: $agpr0, $sgpr86, $sgpr87, $sgpr66_sgpr67, $sgpr68_sgpr69, $sgpr70_sgpr71, $sgpr80_sgpr81, $sgpr82_sgpr83, $sgpr84_sgpr85, $sgpr96_sgpr97, $sgpr98_sgpr99
46+
; GCN-NEXT: {{ $}}
47+
; GCN-NEXT: S_CBRANCH_EXECNZ %bb.1, implicit $exec
48+
; GCN-NEXT: S_BRANCH %bb.4
49+
; GCN-NEXT: {{ $}}
50+
; GCN-NEXT: bb.3:
51+
; GCN-NEXT: successors: %bb.2(0x80000000)
52+
; GCN-NEXT: liveins: $agpr0
53+
; GCN-NEXT: {{ $}}
54+
; GCN-NEXT: $noreg = S_OR_SAVEEXEC_B64 -1, implicit-def $exec, implicit-def dead $scc, implicit $exec
55+
; GCN-NEXT: renamable $vgpr62 = COPY renamable $agpr0
56+
; GCN-NEXT: $exec = S_MOV_B64 killed $noreg
57+
; GCN-NEXT: $sgpr14 = SI_RESTORE_S32_FROM_VGPR killed $vgpr62, 1
58+
; GCN-NEXT: S_BRANCH %bb.2
59+
; GCN-NEXT: {{ $}}
60+
; GCN-NEXT: bb.4:
61+
; GCN-NEXT: $sgpr4_sgpr5 = S_XOR_SAVEEXEC_B64 -1, implicit-def $exec, implicit-def dead $scc, implicit $exec
62+
; GCN-NEXT: $vgpr63 = BUFFER_LOAD_DWORD_OFFSET $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 0, 0, 0, implicit $exec :: (load (s32) from %stack.2, addrspace 5)
63+
; GCN-NEXT: $agpr0 = V_ACCVGPR_WRITE_B32_e64 killed $vgpr63, implicit $exec
64+
; GCN-NEXT: $exec = S_MOV_B64 -1
65+
; GCN-NEXT: $vgpr62 = BUFFER_LOAD_DWORD_OFFSET $sgpr0_sgpr1_sgpr2_sgpr3, $sgpr32, 4, 0, 0, implicit $exec :: (load (s32) from %stack.3, addrspace 5)
66+
; GCN-NEXT: $exec = S_MOV_B64 killed $sgpr4_sgpr5
67+
; GCN-NEXT: SI_RETURN
68+
bb.0:
69+
liveins: $sgpr12, $sgpr13, $sgpr14, $sgpr15
70+
71+
%45:vgpr_32 = IMPLICIT_DEF
72+
SI_SPILL_S32_SAVE $sgpr15, %stack.0, implicit $exec, implicit $sgpr32 :: (store (s32) into %stack.0, addrspace 5)
73+
%16:vgpr_32 = V_AND_B32_e32 1, %45, implicit $exec
74+
75+
bb.1:
76+
successors: %bb.3, %bb.2
77+
78+
S_CBRANCH_EXECZ %bb.2, implicit $exec
79+
S_BRANCH %bb.3
80+
81+
bb.2:
82+
successors: %bb.4(0x04000000), %bb.1(0x7c000000)
83+
liveins: $sgpr86, $sgpr87, $sgpr66_sgpr67, $sgpr68_sgpr69, $sgpr70_sgpr71, $sgpr80_sgpr81, $sgpr82_sgpr83, $sgpr84_sgpr85, $sgpr96_sgpr97, $sgpr98_sgpr99
84+
85+
S_CBRANCH_EXECNZ %bb.1, implicit $exec
86+
S_BRANCH %bb.4
87+
88+
bb.3:
89+
ADJCALLSTACKUP 0, 0, implicit-def dead $scc, implicit-def $sgpr32, implicit $sgpr32
90+
$sgpr14 = SI_SPILL_S32_RESTORE %stack.1, implicit $exec, implicit $sgpr32 :: (load (s32) from %stack.1, addrspace 5)
91+
ADJCALLSTACKDOWN 0, 28, implicit-def dead $scc, implicit-def $sgpr32, implicit $sgpr32
92+
S_BRANCH %bb.2
93+
94+
bb.4:
95+
SI_RETURN
96+
97+
...

0 commit comments

Comments
 (0)