Skip to content

Commit c1add93

Browse files
[mlir][spirv] Change Spirv.GlobalVariableOp builtin -> built_in (#152148)
GlobalVariableOp describes that built_in specifies SPIR-V BuiltIn decoration associated with the op. The attribute was defined as builtin in the tablegen (no uderscore). This was causing correct GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be saved as a new attribute making it impossible to access the built_in attribute through getBuiltinAttr.
1 parent f8a4f61 commit c1add93

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def SPIRV_GlobalVariableOp : SPIRV_Op<"GlobalVariable", [InModuleScope, Symbol]>
451451
OptionalAttr<I32Attr>:$___location,
452452
OptionalAttr<I32Attr>:$binding,
453453
OptionalAttr<I32Attr>:$descriptor_set,
454-
OptionalAttr<StrAttr>:$builtin,
454+
OptionalAttr<StrAttr>:$built_in,
455455
OptionalAttr<SPIRV_LinkageAttributesAttr>:$linkage_attributes
456456
);
457457

0 commit comments

Comments
 (0)