Address review comments

Author: david-arm

llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

@@ -25296,15 +25296,11 @@ static SDValue combineConcatVectorOfSplats(SDNode *N, SelectionDAG &DAG,
       (LegalOperations && !TLI.isOperationLegal(ISD::SPLAT_VECTOR, VT)))
     return SDValue();
 
-  if (!llvm::all_equal(N->op_values()) ||
-      N->getOperand(0).getOpcode() != ISD::SPLAT_VECTOR)
-    return SDValue();
-
-  SDValue Splat = DAG.getSplatValue(N->getOperand(0));
-  if (!Splat)
+  SDValue Op0 = N->getOperand(0);
+  if (!llvm::all_equal(N->op_values()) || Op0.getOpcode() != ISD::SPLAT_VECTOR)
     return SDValue();
 
-  return DAG.getNode(ISD::SPLAT_VECTOR, SDLoc(N), VT, Splat);
+  return DAG.getNode(ISD::SPLAT_VECTOR, SDLoc(N), VT, Op0.getOperand(0));
 }
 
 SDValue DAGCombiner::visitCONCAT_VECTORS(SDNode *N) {
@@ -25508,8 +25504,7 @@ SDValue DAGCombiner::visitVECTOR_INTERLEAVE(SDNode *N) {
     return SDValue();
 
   // Check to see if the identical operand is a splat.
-  SDValue Op0 = N->getOperand(0);
-  SDValue Splat = DAG.getSplatValue(Op0);
+  SDValue Splat = DAG.getSplatValue(N->getOperand(0));
   if (!Splat)
     return SDValue();