Skip to content

Commit f1ca88c

Browse files
authored
[mlir][tosa] Use typeConverter->convertType<T> (#150578)
Since `resultTy` might be nullptr, we should use `dyn_cast` instead of `cast`. Additionally, `typeConverter->convertType<T>` is more appropriate in this context.
1 parent 30728eb commit f1ca88c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgNamed.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ class MaxPool2dConverter : public OpConversionPattern<tosa::MaxPool2dOp> {
735735

736736
bool isUnsigned = op.getType().getElementType().isUnsignedInteger();
737737
ShapedType resultTy =
738-
cast<ShapedType>(getTypeConverter()->convertType(op.getType()));
738+
getTypeConverter()->convertType<ShapedType>(op.getType());
739739
if (!resultTy)
740740
return rewriter.notifyMatchFailure(op, "failed to convert type");
741741
Type resultETy = inputTy.getElementType();

mlir/lib/Conversion/TosaToTensor/TosaToTensor.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -229,8 +229,8 @@ class ReshapeConverter : public OpConversionPattern<tosa::ReshapeOp> {
229229
matchAndRewrite(tosa::ReshapeOp reshape, OpAdaptor adaptor,
230230
ConversionPatternRewriter &rewriter) const final {
231231
auto loc = reshape.getLoc();
232-
auto resultType = cast_if_present<ShapedType>(
233-
getTypeConverter()->convertType(reshape.getType()));
232+
auto resultType =
233+
getTypeConverter()->convertType<ShapedType>(reshape.getType());
234234
if (!resultType) {
235235
return rewriter.notifyMatchFailure(reshape.getLoc(),
236236
"could not convert result type");

0 commit comments

Comments
 (0)