diff --git a/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp b/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp index dd28806e008ed..eaa04fef08c43 100644 --- a/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp +++ b/clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp @@ -432,6 +432,10 @@ RenamerClangTidyCheck::addUsage( if (FixLocation.isInvalid()) return {NamingCheckFailures.end(), false}; + // Skip if in system system header + if (SourceMgr.isInSystemHeader(FixLocation)) + return {NamingCheckFailures.end(), false}; + auto EmplaceResult = NamingCheckFailures.try_emplace(FailureId); NamingCheckFailure &Failure = EmplaceResult.first->second; @@ -455,6 +459,9 @@ RenamerClangTidyCheck::addUsage( void RenamerClangTidyCheck::addUsage(const NamedDecl *Decl, SourceRange UsageRange, const SourceManager &SourceMgr) { + if (SourceMgr.isInSystemHeader(Decl->getLocation())) + return; + if (hasNoName(Decl)) return; diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index e45f870fd4330..2f720d47a0931 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -130,6 +130,10 @@ Changes in existing checks ` check by adding detection for variables introduced by structured bindings. +- Improved :doc:`bugprone-reserved-identifier + ` check by ignoring + declarations in system headers. + - Improved :doc:`bugprone-signed-char-misuse ` check by fixing false positives on C23 enums with the fixed underlying type of signed char. @@ -160,6 +164,10 @@ Changes in existing checks ` check to avoid false positives on pure virtual member functions. +- Improved :doc:`readability-identifier-naming + ` check by ignoring + declarations in system headers. + - Improved :doc:`readability-qualified-auto ` check by adding the option `IgnoreAliasing`, that allows not looking at underlying types of type aliases.