Get my reports dynamic filters - fixed! (ServiceNowDevProgram#830)

Author: smartcarleen

Dynamic Filters/getMyDirectReports/example_manager_data.png

@@ -0,0 +1,50 @@
+var getMyReportsUtil = Class.create();
+getMyReportsUtil.prototype = {
+
+    initialize: function() {
+        this.myReports = []; //array for direct reports sys_ids
+		this.managerID = gs.getUserID(); //set Manager ID to the logged on User
+    },
+
+    getMyDirectReports: function() {
+        //query the user table for users that report to the specifed Manager
+        var userGr = new GlideRecord("sys_user");
+        userGr.addQuery("manager", this.managerID);
+        userGr.addQuery("sys_id", "!=", this.managerID); //recursion protection, exclude the manager
+        userGr.addQuery("active", true); //only active employees
+        userGr.query();
+        while (userGr.next()) {
+			//add the User to the Array
+            this.myReports.push(userGr.getUniqueValue());
+        }
+
+        return this.myReports;
+    },
+
+    getMyReports: function() {
+        this._getReportsRecursive();
+
+        return this.myReports;
+    },
+
+    _getReportsRecursive: function() {
+        //query the user table for users that report to the specifed Manager
+        var userGr = new GlideRecord("sys_user");
+        userGr.addQuery("manager", this.managerID);
+        userGr.addQuery("sys_id", "!=", this.managerID); //recursion protection 1, exclude the manager
+        userGr.addQuery("sys_id", "NOT IN", this.myReports); //recursion protection 2, exclude previously found users
+        userGr.addQuery("active", true); //only active employees
+        userGr.query();
+        while (userGr.next()) {
+			//add the User to the Array
+            this.myReports.push(userGr.getUniqueValue());
+            //keep following the org hierarchy until we don't find any more reports
+			this.managerID = userGr.getUniqueValue();
+            this._getReportsRecursive();
+        }
+    },
+
+
+
+    type: 'getMyReportsUtil'
+};

Dynamic Filters/getMyDirectReports/getMyDirectReports.js

@@ -1,44 +1,67 @@
+# Summary #
 This looping script traverses the User table from a certain point to get either one level of employees or all employees in the hierarchy underneath the logged-on user. There are two functions:
-1. **getMyDirectReports**: gets only users directly reporting to the logged on user
-1. **getMyReports**: gets all users reporting to the logged on user
+1. **One of My Direct Reports**: gets only users directly reporting to the logged on user
+1. **One of My Reports**: gets all users reporting to the logged on user
 
-This solution has three components: one Global Business rule and two Dynamic Filters.
+> [!WARNING]
+> There is some recursion protection, but the use of this script could have performance impacts for very large organizations. Use at your discretion.
+
+**How to Use**
 * Admins can use the script as a Reference Qualifier
-* End Users can select the predefined filter in lists and reports (like with "One of My Assignments").
+* Users (with platform access) can select the predefined filter in lists and reports (like with "One of My Assignments").
 
-There is some recursion protection; the script checks to see if it has already collected the User before it tries to get their direct reports.
+# Solution #
+This solution has three main components:
+* 1 Client Callable Script Include
+* 2 Dynamic Filters
 
-**IMPORTANT: The use of this script could have performance impacts for very large organizations. Use at your discretion.**
+> [!NOTE]
+> You will also need to create an ACL for your client callable script include.  Think through other security rules before using this filter broadly for users without roles. OOTB Users without roles are often restricted to seeing only their items, for example, a User without itil or snc_incident_read typically cannot see other user's Incidents unless they are the Opened by or are on the Watch list. Make sure you test as the users you hope to publish this item to.
 
-**Business Rule**
+## Script Include (sys_script_include) ##
 
 | Field | Value |
 |---|---|
-| Name | getMyDirectReports |
-| Table | Global [global] |
-| Advanced | true |
-| Script | <em>see [getMyDirectReports.js](getMyDirectReports.js) in this folder</em> |
+| Name | getMyReportsUtil |
+| Client Callable | true |
+| Script | <em>see [getMyReportsUtil.js](getMyReportsUtil.js)</em> |
+
+## Dynamic Filter Option (sys_filter_option_dynamic) ##
 
-**Dynamic Filter Option (sys_filter_option_dynamic)**
+### One of My Direct Reports ###
 
 | Field | Value |
 |---|---|
 | Label | One of My Direct Reports |
-| Script | getMyDirectReports() |
+| Script | new global.getMyReportsUtil().getMyDirectReports() |
 | Field type | Reference |
 | Reference Table | User [sys_user] |
 | Order | 500 |
-| Reference script | Business Rule: getMyDirectReports |
+| Roles | Choose the same role(s) you added to the Script Include ACL |
+| Reference script | Script Include: getMyReportsUtil |
 | Available for filter | true |
 | Available for ref qual | true |
 
+**Example Incident list filtered by Caller is One of My Direct Reports**
+![Example Incident list filtered by Caller is One of My Direct Reports](one_of_my_direct_reports.png)
+
+### One of My Reports ###
+
 | Field | Value |
 |---|---|
 | Label | One of My Reports |
-| Script | getMyReports() |
+| Script | new global.getMyReportsUtil().getMyReports() |
 | Field type | Reference |
 | Reference Table | User [sys_user] |
 | Order | 600 |
-| Reference script | Business Rule: getMyDirectReports |
+| Roles | Choose the same role(s) you added to the Script Include ACL |
+| Reference script | Script Include: getMyReportsUtil |
 | Available for filter | true |
 | Available for ref qual | true |
+
+**Example Incident list filtered by Caller is One of My Reports**
+![Example Incident list filtered by Caller is One of My Reports](one_of_my_reports.png)
+
+ ### Example Manager Data for the screenshots above ###
+
+![Example Manager Data](example_manager_data.png)