option to change the app name

[PeterThomasAwen]

Can a variable be added inside the values.yaml such as appName which allows the deployment app name value to be set from the values.yaml file currently its hard coded to "app" (which doesn't add any value) and requires a downloading the templates and making the change manually?

Default value for this could be k8seventlogger or similar?

[max-rocket-internet]

Do you mean the name of the container or the name of the deployment?

[PeterThomasAwen]

HI Max,

I'm talking about the name of the container in the deployment file.

`      serviceAccountName: {{ include "k8s-event-logger.fullname" . }}
      containers:
        - name: app
          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"`

Can we place that as another variable to reference from the values say having the values file as,

image:
  containerName: eventrouter
  repository: maxrocketinternet/k8s-event-logger
  tag: "2.2"
  pullPolicy: IfNotPresent

Then reference that in the deployment file

 `      serviceAccountName: {{ include "k8s-event-logger.fullname" . }}
      containers:
        - name: {{.Values.image.containerName}}
          image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"`

I can push in a PR for this if that helps?
I just didn't know if you'd have any objections to this or if it was left hard coded for a reason as the rest of the values in the deployment seem to reference the values file?

[max-rocket-internet]

I can push in a PR for this if that helps?

Sure go for it, just keep the default as is 🙌

But why does it matter for you though?

[PeterThomasAwen]

So we use Kibana for logging,
That value gets pushed in to app field (which we use to views say logs from one service)
So with the default values that was effectively coming in to our logs as
app: app
Which doesn't really work for us I need it to identify the type of service it is.

[PeterThomasAwen]

created that pr for you.

[max-rocket-internet]

Resolved in #42