Removes 'defines correct option sets'. Closes pnp#4068

Author: nicodecleyre

src/m365/aad/commands/app/app-add.spec.ts

@@ -6503,13 +6503,6 @@ describe(commands.APP_ADD, () => {
     assert.strictEqual(actual, true);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [
-      { options: ['name', 'manifest'] }
-    ]);
-  });
-
   it('creates AAD app reg for a web app from a manifest with redirectUris and options overriding them', async () => {
     sinon.stub(request, 'get').callsFake(opts => {
       if (opts.url === 'https://graph.microsoft.com/v1.0/myorganization/servicePrincipals?$select=appId,appRoles,id,oauth2PermissionScopes,servicePrincipalNames') {

src/m365/aad/commands/o365group/o365group-recyclebinitem-remove.spec.ts

@@ -112,11 +112,6 @@ describe(commands.O365GROUP_RECYCLEBINITEM_REMOVE, () => {
     assert.notStrictEqual(command.description, null);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'displayName', 'mailNickname'] }]);
-  });
-
   it('fails validation when id is not a valid GUID', async () => {
     const actual = await command.validate({
       options: {

src/m365/aad/commands/o365group/o365group-recyclebinitem-restore.spec.ts

@@ -106,11 +106,6 @@ describe(commands.O365GROUP_RECYCLEBINITEM_RESTORE, () => {
     assert.notStrictEqual(command.description, null);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'displayName', 'mailNickname'] }]);
-  });
-
   it('fails validation if the id is not a valid GUID', async () => {
     const actual = await command.validate({ options: { id: 'abc' } }, commandInfo);
     assert.notStrictEqual(actual, true);

src/m365/adaptivecard/commands/adaptivecard-send.spec.ts

@@ -820,11 +820,6 @@ describe(commands.SEND, () => {
     assert.strictEqual(actual, true);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['title', 'card'] }]);
-  });
-
   it('supports specifying unknown options', () => {
     assert.strictEqual(command.allowUnknownOptions(), true);
   });

src/m365/booking/commands/business/business-get.spec.ts

@@ -78,11 +78,6 @@ describe(commands.BUSINESS_GET, () => {
     assert.notStrictEqual(command.description, null);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'name'] }]);
-  });
-
   it('defines correct properties for the text output', () => {
     assert.deepStrictEqual(command.defaultProperties(), ['id', 'displayName', 'businessType', 'phone', 'email', 'defaultCurrencyIso']);
   });

src/m365/planner/commands/bucket/bucket-get.spec.ts

@@ -257,11 +257,6 @@ describe(commands.BUCKET_GET, () => {
     assert.strictEqual(actual, true);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'name'] }]);
-  });
-
   it('fails validation when no groups found', async () => {
     sinon.stub(request, 'get').callsFake((opts) => {
       if (opts.url === `https://graph.microsoft.com/v1.0/groups?$filter=displayName eq '${formatting.encodeQueryParameter(validOwnerGroupName)}'`) {

src/m365/planner/commands/bucket/bucket-remove.spec.ts

@@ -150,11 +150,6 @@ describe(commands.BUCKET_REMOVE, () => {
     assert.notStrictEqual(command.description, null);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'name'] }]);
-  });
-
   it('fails validation id when id and plan details are specified', async () => {
     const actual = await command.validate({
       options: {

src/m365/planner/commands/bucket/bucket-set.spec.ts

@@ -145,11 +145,6 @@ describe(commands.BUCKET_SET, () => {
     assert.notStrictEqual(command.description, null);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'name'] }]);
-  });
-
   it('fails validation id when id and plan details are specified', async () => {
     const actual = await command.validate({
       options: {

src/m365/planner/commands/plan/plan-get.spec.ts

@@ -116,11 +116,6 @@ describe(commands.PLAN_GET, () => {
     assert.notStrictEqual(actual, true);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'title'] }]);
-  });
-
   it('fails validation when both ownerGroupId and ownerGroupName are specified when using title', async () => {
     const actual = await command.validate({
       options: {

src/m365/planner/commands/plan/plan-remove.spec.ts

@@ -112,11 +112,6 @@ describe(commands.PLAN_REMOVE, () => {
     assert.notStrictEqual(command.description, null);
   });
 
-  it('defines correct option sets', () => {
-    const optionSets = command.optionSets;
-    assert.deepStrictEqual(optionSets, [{ options: ['id', 'title'] }]);
-  });
-
   it('fails validation when id and ownerGroupId is specified', async () => {
     const actual = await command.validate({
       options: {