Skip to content

Commit 826a1e9

Browse files
authored
Merge pull request pnp#62 from SharePoint/dev
Merging for 1.2.5 release
2 parents eb68fb6 + 8226fdd commit 826a1e9

File tree

6 files changed

+50
-7
lines changed

6 files changed

+50
-7
lines changed

CHANGELOG.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,20 @@
11
# Releases
22

3+
## 1.2.5
4+
5+
**Fixes**
6+
7+
- Undo `ListView` item selection after items array updates [#55](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/55)
8+
39
## 1.2.4
410

511
**Enhancements**
6-
- Hiding placeholder web part on small zones
12+
13+
- Hiding placeholder title on small zones
714

815
**Fixes**
9-
- iFrame dialog reference fix [#52 - Need some more implementation documentation on IFrameDialog](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/52)
16+
17+
- iFrame dialog reference fix [#52](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/52)
1018

1119
## 1.2.3
1220

docs/documentation/docs/about/release-notes.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,20 @@
11
# Releases
22

3+
## 1.2.5
4+
5+
**Fixes**
6+
7+
- Undo `ListView` item selection after items array updates [#55](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/55)
8+
39
## 1.2.4
410

511
**Enhancements**
6-
- Hiding placeholder web part on small zones
12+
13+
- Hiding placeholder title on small zones
714

815
**Fixes**
9-
- iFrame dialog reference fix [#52 - Need some more implementation documentation on IFrameDialog](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/52)
16+
17+
- iFrame dialog reference fix [#52](https://github.com/SharePoint/sp-dev-fx-controls-react/issues/52)
1018

1119
## 1.2.3
1220

docs/documentation/docs/index.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1-
# Reusable React controls for your SharePoint Framework solutions
1+
# Reusable React controls for your SharePoint Framework solutions ![](https://img.shields.io/npm/v/@pnp/spfx-controls-react.svg)
22

33
This repository provides developers with a set of reusable React controls that can be used in SharePoint Framework (SPFx) solutions. The project provides controls for building web parts and extensions.
44

5+
!!! attention The controls project has a minimal dependency on SharePoint Framework version `1.3.0`. Be aware that the controls might not work in solutions your building for on-premises. As for on-premises solutions version `1.1.0` is currently used.
6+
57
## Getting started
68

79
### Installation

package.json

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@pnp/spfx-controls-react",
33
"description": "Reusable React controls for SharePoint Framework solutions",
4-
"version": "1.2.4",
4+
"version": "1.2.5",
55
"engines": {
66
"node": ">=0.10.0"
77
},
@@ -65,5 +65,12 @@
6565
"url": "https://github.com/SharePoint/sp-dev-fx-controls-react/issues"
6666
},
6767
"main": "lib/index.js",
68-
"homepage": "https://github.com/SharePoint/sp-dev-fx-controls-react"
68+
"homepage": "https://github.com/SharePoint/sp-dev-fx-controls-react",
69+
"contributors": [
70+
"Gove, Russell <[email protected]>",
71+
"Kent Chris <>",
72+
"Rodrigues, Joel <>",
73+
"Struyf, Elio <[email protected]>",
74+
"Terentiev, Alex <>"
75+
]
6976
}

src/controls/listView/ListView.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ export class ListView extends React.Component<IListViewProps, IListViewState> {
5959
this._setSelectedItems();
6060

6161
if (!isEqual(prevProps, this.props)) {
62+
// Reset the selected items
63+
this._selection.setItems(this.props.items, true);
64+
// Process list view properties
6265
this._processProperties();
6366
}
6467
}

src/webparts/controlsTest/components/ControlsTest.tsx

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,19 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
7070
console.log('Items:', items);
7171
}
7272

73+
/**
74+
* Deletes second item from the list
75+
*/
76+
private deleteItem = () => {
77+
const { items } = this.state;
78+
if (items.length >= 2) {
79+
items.splice(1, 1);
80+
this.setState({
81+
items: items
82+
});
83+
}
84+
}
85+
7386
/**
7487
* Renders the component
7588
*/
@@ -212,6 +225,8 @@ export default class ControlsTest extends React.Component<IControlsTestProps, IC
212225
compact={true}
213226
selectionMode={SelectionMode.multiple}
214227
selection={this._getSelection} />
228+
229+
<p><a href="javascript:;" onClick={this.deleteItem}>Deletes second item</a></p>
215230
</div>
216231
);
217232
}

0 commit comments

Comments
 (0)