JSON schema - Is definitions keyword supported?

[omkarnix]

Hi, I m facing exactly same issue as described in wework#29

Can someone please share an update? @philsturgeon

[philsturgeon]

These issues are just “does something work?” so I don’t really understand the question.

What are you trying to do.

What is the expected outcome.

What is the actual outcome? Errors, unexpected behaviour, etc.

[jonluca]

I see what the problem is, the json-schema-walker won't walk definitions that aren't referenced by a $ref. This should probably be supported though.

If a schema had a definitions property (which is valid in JSONSchema), and only some of those entries were referenced, only the referenced ones were converted, leaving the schema in a broken invalid state.

#30 This PR adds a new property (which is true by default, but can be disabled) to convert these definitions as well - convertUnreferencedDefinitions

[philsturgeon]

Awesome, thanks again @jonluca. If you find a moment to throw some docs up for that new property that'd help folks find it. You've been doing great on these PRs, I really appreciate it!

[jonluca]

Cool, will do it in a bit. No problem :)

I think the other issues on this repo can be closed out as well. They should all be cleared/done

[philsturgeon]

@jonluca thank you, closed them all but this one. #32