Skip to content

Commit 81b98f3

Browse files
committed
Refactoring: rename evaluate to execute on actions
1 parent 9c0d5d1 commit 81b98f3

File tree

170 files changed

+233
-238
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

170 files changed

+233
-238
lines changed

headers/modsecurity/actions/action.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,12 +66,12 @@ class Action {
6666

6767
virtual ~Action() { }
6868

69-
virtual std::string evaluate(const std::string &exp,
69+
virtual std::string execute(const std::string &exp,
7070
Transaction *transaction);
71-
virtual bool evaluate(RuleWithActions *rule, Transaction *transaction);
72-
virtual bool evaluate(RuleWithActions *rule, Transaction *transaction,
71+
virtual bool execute(RuleWithActions *rule, Transaction *transaction);
72+
virtual bool execute(RuleWithActions *rule, Transaction *transaction,
7373
RuleMessage &ruleMessage) {
74-
return evaluate(rule, transaction);
74+
return execute(rule, transaction);
7575
}
7676
virtual bool init(std::string *error) { return true; }
7777
virtual bool isDisruptive() { return false; }

src/actions/accuracy.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,8 @@ bool Accuracy::init(std::string *error) {
3939
}
4040

4141

42-
bool Accuracy::evaluate(RuleWithActions *rule, Transaction *transaction) {
42+
bool Accuracy::execute(RuleWithActions *rule, Transaction *transaction) {
43+
rule->setAccuracy(m_accuracy);
4344
return true;
4445
}
4546

src/actions/accuracy.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class Accuracy : public Action {
3333
: Action(action, ConfigurationKind),
3434
m_accuracy(0) { }
3535

36-
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
36+
bool execute(RuleWithActions *rule, Transaction *transaction) override;
3737
bool init(std::string *error) override;
3838
int getAccuracy() const { return m_accuracy; }
3939

src/actions/action.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,13 @@ namespace modsecurity {
4545
namespace actions {
4646

4747

48-
std::string Action::evaluate(const std::string &value,
48+
std::string Action::execute(const std::string &value,
4949
Transaction *transaction) {
5050
return value;
5151
}
5252

5353

54-
bool Action::evaluate(RuleWithActions *rule, Transaction *transaction) {
54+
bool Action::execute(RuleWithActions *rule, Transaction *transaction) {
5555
return true;
5656
}
5757

src/actions/audit_log.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace modsecurity {
2727
namespace actions {
2828

2929

30-
bool AuditLog::evaluate(RuleWithActions *rule, Transaction *transaction,
30+
bool AuditLog::execute(RuleWithActions *rule, Transaction *transaction,
3131
RuleMessage &rm) {
3232
transaction->messageSetNoAuditLog(false);
3333
return true;

src/actions/audit_log.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class AuditLog : public Action {
3535
explicit AuditLog(const std::string &action)
3636
: Action(action, RunTimeOnlyIfMatchKind) { }
3737

38-
bool evaluate(RuleWithActions *rule, Transaction *transaction,
38+
bool execute(RuleWithActions *rule, Transaction *transaction,
3939
RuleMessage &rm) override;
4040
};
4141

src/actions/block.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace modsecurity {
2929
namespace actions {
3030

3131

32-
bool Block::evaluate(RuleWithActions *rule, Transaction *transaction,
32+
bool Block::execute(RuleWithActions *rule, Transaction *transaction,
3333
RuleMessage &rm) {
3434
ms_dbg_a(transaction, 8, "Marking request as disruptive.");
3535
return true;

src/actions/block.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Block : public Action {
3838
Block(const Block &a) = delete;
3939
Block &operator=(const Block &a) = delete;
4040

41-
bool evaluate(RuleWithActions *rule, Transaction *transaction,
41+
bool execute(RuleWithActions *rule, Transaction *transaction,
4242
RuleMessage &rm) override;
4343
};
4444

src/actions/capture.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ namespace modsecurity {
3232
namespace actions {
3333

3434

35-
bool Capture::evaluate(RuleWithActions *rule, Transaction *transaction) {
35+
bool Capture::execute(RuleWithActions *rule, Transaction *transaction) {
3636
return true;
3737
}
3838

src/actions/capture.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class Capture : public Action {
3131
explicit Capture(const std::string &action)
3232
: Action(action, RunTimeOnlyIfMatchKind) { }
3333

34-
bool evaluate(RuleWithActions *rule, Transaction *transaction) override;
34+
bool execute(RuleWithActions *rule, Transaction *transaction) override;
3535
};
3636

3737

0 commit comments

Comments
 (0)