cosmetics: Please cppcheck

zimmerle · zimmerle · commit ca52e88e603b · 2021-07-19T10:11:15.000-03:00
diff --git a/headers/modsecurity/transaction.h b/headers/modsecurity/transaction.h
@@ -303,7 +303,7 @@ class TransactionSecMarkerManagement {
         if (m_marker) {
             return m_marker;
         } else {
-            throw;
+            throw std::runtime_error("Error get current marker\n");
         }
     }
 
diff --git a/src/rule_with_actions.cc b/src/rule_with_actions.cc
@@ -120,7 +120,7 @@ RuleWithActions::RuleWithActions(
                 delete a;
                 std::cout << "General failure, action: " << a->m_name;
                 std::cout << " has an unknown type." << std::endl;
-                throw;
+                throw std::runtime_error("Unexpected condition. Action without a type.\n");
             }
         }
         delete actions;
diff --git a/test/cppcheck_suppressions.txt b/test/cppcheck_suppressions.txt
@@ -57,6 +57,7 @@ knownConditionTrueFalse:src/operators/verify_svnr.cc:87
 
 noExplicitConstructor:seclang-parser.hh
 constParameter:seclang-parser.hh
+accessMoved:seclang-parser.hh
 
 unusedFunction
 missingIncludeSystem

Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ class TransactionSecMarkerManagement {`
`303`	`303`	`if (m_marker) {`
`304`	`304`	`return m_marker;`
`305`	`305`	`} else {`
`306`		`- throw;`
	`306`	`+ throw std::runtime_error("Error get current marker\n");`
`307`	`307`	`}`
`308`	`308`	`}`
`309`	`309`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ RuleWithActions::RuleWithActions(`
`120`	`120`	`delete a;`
`121`	`121`	`std::cout << "General failure, action: " << a->m_name;`
`122`	`122`	`std::cout << " has an unknown type." << std::endl;`
`123`		`- throw;`
	`123`	`+ throw std::runtime_error("Unexpected condition. Action without a type.\n");`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`	`delete actions;`